[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #43: [FLINK-31748] Dummy implementation to fix compilation failure

["reswqa (via GitHub)" <gi...@apache.org>]

reswqa commented on code in PR #43:
URL: https://github.com/apache/flink-connector-pulsar/pull/43#discussion_r1165713014


##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/PulsarSourceFetcherManager.java:
##########
@@ -86,6 +86,11 @@ public void addSplits(List<PulsarPartitionSplit> splitsToAdd) {
         }
     }
 
+    // @Override // to keep compatible with Flink 1.17
+    public void removeSplits(List<PulsarPartitionSplit> splitsToRemove) {
+        // empty - wait for FLINK-31748 to implement it.

Review Comment:
   Maybe we can add a `TODO` tag here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org