[lang] Unit Tests Also: [lang][patch] New submission: FastDateFormat, FastDateFormatTest

[Henri Yandell <ba...@generationjava.com>]

You seem to use assertFalse and assertNotSame, which I think are JUnit
3.8.1 functions and not 3.7. [I'm a little unsure, as I think the
junit-3.7.jar on my machine is actually a junit-3.8.1.jar due to some
screwup].

Against 3.8.1, these tests run fine. Against 3.7 they don't. Anyone got a
reason not to update to 3.8.1?

Lang also doesn't pass its enum/ tests at the moment. It's a serialization
error:

1) testOperationSerialization(org.apache.commons.lang.enum.EnumTest)java.lang.NoClassDefFoundError:
org/apache/commons/lang/enum/OperationEnum$1

Anyone got this in hand? Or able to confirm that this is true?

Hen

On Mon, 6 Jan 2003, Sean Schofield wrote:

> FastDateFormat is a new class for the time subpackage of commons-lang.
>  It is based on a class originally written by Brian O'Neill for a
> non-jakarta-related open source project.  It has been reused (and
> modified) with his permission.
>
> I wrote FastDateFormatTest to go along with this.  A few unit tests are
> still missing but this is because I would like to remove some of the
> untested methods from FastDateFormat if we can reach a consensus on this.
>
> Please see my follow-up email regarding the changes I made to the
> original source code, and issues that I feel we should discuss regarding
> the future direction of this class.
>
> Regards,
>
> - sean schofield
>
> NOTE: zipped files do not contain path info (so they will have to be
> dropped into the test and source directories - package is
> org.apache.commons.lang.time)
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [lang] Unit Tests

[Stephen Colebourne <sc...@btopenworld.com>]

From: "Henri Yandell" <ba...@generationjava.com>
> You seem to use assertFalse and assertNotSame, which I think are JUnit
> 3.8.1 functions and not 3.7. [I'm a little unsure, as I think the
> junit-3.7.jar on my machine is actually a junit-3.8.1.jar due to some
> screwup].
>
> Against 3.8.1, these tests run fine. Against 3.7 they don't. Anyone got a
> reason not to update to 3.8.1?
No, we might as well.


> Lang also doesn't pass its enum/ tests at the moment. It's a serialization
> error:
>
> 1)
testOperationSerialization(org.apache.commons.lang.enum.EnumTest)java.lang.N
oClassDefFoundError:
> org/apache/commons/lang/enum/OperationEnum$1
>
> Anyone got this in hand? Or able to confirm that this is true?
I don't see this on my setup (Eclipse, Win98, JDK1.4.1). More info?

Stephen


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [lang][patch] new submission: revised FastDateFormatTest

[Henri Yandell <ba...@generationjava.com>]

Tests, works and in.

Hen

On Tue, 7 Jan 2003, Sean Schofield wrote:

> >
> >
> >Against 3.8.1, these tests run fine. Against 3.7 they don't. Anyone got a
> >reason not to update to 3.8.1?
> >
> Hen,
>
> I'm submitting a new copy of FastDateFormatTest that is compatible with
> 3.7.  Can you add this file (along with FastDateFormat and the patch I
> sent yesterday)?
>
> I still think we might want to upgrade to 3.8.1 but lets keep this
> moving for now until that issue is resolved.
>
> - sean
>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

[lang][patch] new submission: revised FastDateFormatTest

[Sean Schofield <ne...@schof.com>]

>
>
>Against 3.8.1, these tests run fine. Against 3.7 they don't. Anyone got a
>reason not to update to 3.8.1?
>
Hen,

I'm submitting a new copy of FastDateFormatTest that is compatible with 
3.7.  Can you add this file (along with FastDateFormat and the patch I 
sent yesterday)?

I still think we might want to upgrade to 3.8.1 but lets keep this 
moving for now until that issue is resolved.

- sean

Re: [lang] Unit Tests Also: [lang][patch] New submission: FastDateFormat, FastDateFormatTest

[Sean Schofield <ne...@schof.com>]

Henri Yandell wrote:

>You seem to use assertFalse and assertNotSame, which I think are JUnit
>3.8.1 functions and not 3.7. [I'm a little unsure, as I think the
>junit-3.7.jar on my machine is actually a junit-3.8.1.jar due to some
>screwup].
>
>Against 3.8.1, these tests run fine. Against 3.7 they don't. Anyone got a
>reason not to update to 3.8.1?
>
Oops.  I wrote the test cases using JBuilder 8.0 which apparently has 
3.8 for JUnit.  I could rewrite these tests to conform to 3.7 or we 
could upgrade commons-lang to 3.8.1 as you suggested.  I'm ok with 
either option but it might be a good idea to take advantage of the new 
junit stuff ....

- sean

>  
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>