You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by navis <gi...@git.apache.org> on 2015/10/23 05:55:04 UTC

[GitHub] phoenix pull request: PHOENIX-2349 SortOrderExpressionTest.toChar(...

GitHub user navis opened a pull request:

    https://github.com/apache/phoenix/pull/125

    PHOENIX-2349 SortOrderExpressionTest.toChar() is failing in different locale

    For example in ko.kr,
    ```
    Tests run: 24, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.025 sec <<< FAILURE! - in org.apache.phoenix.expression.SortOrderExpressionTest
    toChar(org.apache.phoenix.expression.SortOrderExpressionTest)  Time elapsed: 0.007 sec  <<< FAILURE!
    org.junit.ComparisonFailure: expected:<12/11/01 12:00 [AM]> but was:<12/11/01 12:00 [오전]>
    	at org.junit.Assert.assertEquals(Assert.java:115)
    	at org.apache.phoenix.expression.SortOrderExpressionTest.evaluateAndAssertResult(SortOrderExpressionTest.java:322)
    	at org.apache.phoenix.expression.SortOrderExpressionTest.evaluateAndAssertResult(SortOrderExpressionTest.java:312)
    	at org.apache.phoenix.expression.SortOrderExpressionTest.toChar(SortOrderExpressionTest.java:149)
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/navis/phoenix PHOENIX-2349

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #125
    
----
commit 3d00dc39ec93ab4eacf3d341b618fc8a23b0a249
Author: navis.ryu <na...@apache.org>
Date:   2015-10-23T03:53:59Z

    PHOENIX-2349 SortOrderExpressionTest.toChar() is failing in different locale

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---