You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by fh...@apache.org on 2006/09/13 16:44:42 UTC

svn commit: r442995 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java

Author: fhanik
Date: Wed Sep 13 07:44:41 2006
New Revision: 442995

URL: http://svn.apache.org/viewvc?view=rev&rev=442995
Log:
adjustment according to APR fix

Modified:
    tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java?view=diff&rev=442995&r1=442994&r2=442995
==============================================================================
--- tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java Wed Sep 13 07:44:41 2006
@@ -772,8 +772,8 @@
             recycle();
             return SocketState.CLOSED;
         } else if (!comet) {
-            recycle();
             socket.getPoller().add(socket);
+            recycle();
             return SocketState.OPEN;
         } else {
             socket.getPoller().add(socket);



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r442995 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java

Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
The *Nio* code is essentially the *Apr* code, but using the java.nio 
package. For "blocking reads" it uses a thread suspend mechanism, and 
for "blocking write" it uses busy wait.
this can be improved on of course, but I haven't had time to wrap my 
head around it

Filip


Remy Maucherat wrote:
> fhanik@apache.org wrote:
>> Author: fhanik
>> Date: Wed Sep 13 07:44:41 2006
>> New Revision: 442995
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=442995
>> Log:
>> adjustment according to APR fix
>
> Didn't know you were using that code too. Cute side effect: it adds 0 
> to the poller :D
>
> Rémy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r442995 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java

Posted by Remy Maucherat <re...@apache.org>.
fhanik@apache.org wrote:
> Author: fhanik
> Date: Wed Sep 13 07:44:41 2006
> New Revision: 442995
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=442995
> Log:
> adjustment according to APR fix

Didn't know you were using that code too. Cute side effect: it adds 0 to 
the poller :D

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org