You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2023/12/05 18:33:44 UTC
[PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
szetszwo opened a new pull request, #5737:
URL: https://github.com/apache/ozone/pull/5737
## What changes were proposed in this pull request?
In Ozone, we have many ugly code like the following in order to satisfy the 80 line width requirement.
```java
//StorageContainerManager.java
FixedThreadPoolWithAffinityExecutor<IncrementalContainerReportFromDatanode,
ContainerReport> incrementalReportExecutors =
new FixedThreadPoolWithAffinityExecutor<>(
EventQueue.getExecutorName(
SCMEvents.INCREMENTAL_CONTAINER_REPORT,
incrementalContainerReportHandler),
incrementalContainerReportHandler, queues, eventQueue,
IncrementalContainerReportFromDatanode.class, executors,
reportExecutorMap);
```
Ugly code, is not only a cosmetic issue, leads to more bugs since it makes the code harder to read.
We are currently following the Sun Code Conventions
- https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html#313
which says
- 4.1 Line Length
- Avoid lines longer than 80 characters, since they're not handled well by many terminals and tools.
This is probably true 20+ years ago. (It might be true for the old SUN workstations?)
## What is the link to the Apache JIRA
HDDS-9841
## How was this patch tested?
Try line longer than 80 character and run checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416797396
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
> to say a veto can be overruled by 1 or 2 people(coincidently from same org)
@adoroszlai With all due respect none of them there said we tend to say @anuengineer vote isn't valid. The veto isn't valid is being said here. maybe my communication issues. I am talking about veto being overruled, not about the code change. If it was a normal proposal, I would have myself +1 this.
Neverthless, I am nobody to stop anyone from clicking on the merge button neither I am aware what happens in this case, just lets remember & get this marked in the next Board Report for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #5737:
URL: https://github.com/apache/ozone/pull/5737#issuecomment-1844135319
https://github.com/apache/ozone/pull/921 @szetszwo Thanks you for bring this discussion back, i support this proposal totally!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo closed pull request #5737: HDDS-9841. Increase checkstyle LineLength.
URL: https://github.com/apache/ozone/pull/5737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416734649
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
Well I don't want to be the bad guy blocking you folks for something I don't consider a problem(code wise).
But this is gonna set an example, so for posterity when this is used as an example by some other people(or me) to say a veto can be overruled by 1 or 2 people(coincidently from same org) on a PR itself in Ozone by stating the reason is invalid, which wasn't actually of 1+1=2 type, it was an accepted activity then, but I was in no way in favour of that. The other people didn't respect the ByLaws.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416264248
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
@ayushtkn , thanks for pointing out [comment-Jun 3, 2020](https://github.com/apache/ozone/pull/921#issuecomment-638231484).
Indeed, that comment did not veto it. The veto comment was [comment-Jun 14, 2020](https://github.com/apache/ozone/pull/921#issuecomment-643829659), which was based on
- https://accessibility.digital.gov/visual-design/typography/
It seems irrelevant since it talks about **textual information** but not computer code. It also says
> ... Don’t make lines too long or too short: 45-75 characters per line ...
Are we going to enforce min line length 45?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on PR #5737:
URL: https://github.com/apache/ozone/pull/5737#issuecomment-1849018131
#921 has been reopened and looks to be moving forward. Please add any +1's there, as this PR will probably be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416249520
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
this change is vetoed long back:
https://github.com/apache/ozone/pull/921#issuecomment-638231484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416271304
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
I am a strong +1 on committing this. Its a constant frustration trying to read and write this needlessly wrapped code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416264248
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
@ayushtkn , thanks for pointing out [comment-Jun 15, 2020](https://github.com/apache/ozone/pull/921#issuecomment-638231484).
Indeed, that comment did not veto it. The veto comment was [comment-Jun 14, 2020](https://github.com/apache/ozone/pull/921#issuecomment-643829659), which was based on
- https://accessibility.digital.gov/visual-design/typography/
It seems irrelevant since it talks about **textual information** but not computer code. It also says
> ... Don’t make lines too long or too short: 45-75 characters per line ...
Are we going to enforce min line length 45?
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
@ayushtkn , thanks for pointing out [comment-Jun 15, 2020](https://github.com/apache/ozone/pull/921#issuecomment-638231484).
Indeed, that comment did not veto it. The veto comment was [comment-Jun 14, 2020](https://github.com/apache/ozone/pull/921#issuecomment-643829659), which was based on
- https://accessibility.digital.gov/visual-design/typography/
It seems irrelevant since it talks about **textual information** but not computer code. It also says
> ... Don’t make lines too long or too short: 45-75 characters per line ...
Are we going to enforce min line length 45?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416782835
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
> overruled by 1 or 2 people(coincidently from same org)
@ayushtkn If you look at the previous PR, it was started by someone from other "org", and supported by way more than 1 or 2 people, also from various orgs, so please don't distort the facts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "Galsza (via GitHub)" <gi...@apache.org>.
Galsza commented on PR #5737:
URL: https://github.com/apache/ozone/pull/5737#issuecomment-1843104086
+1 from me as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #5737:
URL: https://github.com/apache/ozone/pull/5737#issuecomment-1841616631
Since there was a big discussion in HDDS-3583, let's wait for 3 days before merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416313457
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
Just speaking about the process:
If you read the hadoop by laws as well
https://hadoop.apache.org/bylaws.html
> The validity of a veto, if challenged, can be confirmed by anyone who has a binding vote. This does not necessarily signify agreement with the veto - merely that the veto is valid.
Means that veto is valid only, Anu is a committer & he gave a reason, we are not convinced that doesn't make that invalid. This my understanding, & I have never seen a veto getting overruled, I maybe missing some catch there. Maybe we can relaunch that existing mail thread & someone with more insights on the process can help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416292909
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
I personally don't have any issue with this change, a lot of projects have 120 as the limit(ex. hive)
But from the process point of view it isn't allowed by Apache ByLaws
https://www.apache.org/foundation/voting.html#votes-on-code-modification
It reads
``
but -1 votes are vetos and kill the proposal dead until all vetoers withdraw their -1 votes.
``
Regarding the veto
https://www.apache.org/foundation/voting.html#Veto
``
A -1 vote by a qualified voter stops a code-modification proposal in its tracks. This constitutes a veto, and it cannot be overruled nor overridden by anyone. Vetoes stand until and unless the individual withdraws their veto.
``
So, by this unless @anuengineer doesn't withdraw his veto, his vote can not be overruled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #5737:
URL: https://github.com/apache/ozone/pull/5737#issuecomment-1849035354
Yes, let's close this and merge #921 instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416299791
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
@ayushtkn reading the same section further:
> the voter must provide with the veto a technical justification showing why the change is bad. A veto without a justification is invalid and has no weight.
The soundness of the justification provided previously has been questioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416348514
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
> ... gave a reason ...
A reason is not necessarily a valid reason. Someone could say, "Since 1+1=2, I veto the proposal." This does not sound valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416797396
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
> to say a veto can be overruled by 1 or 2 people(coincidently from same org)
@adoroszlai With all due respect none of them there said we tend to say @anuengineer vote isn't valid. The veto isn't valid is being said here. maybe my communication issues. I am talking about veto being overruled, not about the code change. If it was a normal proposal, I would have myself +1 this.
Neverthless, I am nobody to stop anyone from clicking on the merge button neither I am aware what happens in this case, just lets remember & get this marked in the next Board Report for sure.
Side Note: It is better to seak clarifications rather than blaming someone immediately for distorting facts. Someone might get discouraged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9841. Increase checkstyle LineLength. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416825700
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
@ayushtkn , I understand you concern -- I did mention explicitly in https://github.com/apache/ozone/pull/921#issuecomment-1841610769 that the veto should be considered as invalid. The veto is actually similar to 1+1=2 type -- 45-75 line length is good for `textual information` but it definitely is not good for computer programs. It is nonsense to enforce min line length in computer programs. It is also nonsense to enforce 75 max line length. How could it be valid?
On the other hands, short line length such as 80 does lead to many problems -- code readability, encouraging short variable names, unnecessary code formatting efforts, etc. All these problems were not considered in the `textual information` recommandation.
Thanks for bring it up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org