You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/21 07:23:16 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Pearl1594 opened a new pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483
### Description
This PR fixes the intermittent failure observed in test_02_list_snapshots_with_removed_data_store of the test_snapshot.py test suite. This reason for the failure seems to be that the volume created may already be present on the store (primary store) to which it is being migrated to.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Ran the test_snapshot.py test suite multiple times to validate that when volume is present on the store to which it is being migrated to(created storage pool), it chooses another pool from the available list of storage pools
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-924700611
@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-925175741
<b>Trillian test result (tid-2159)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34599 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5483-t2159-xenserver-71.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-924699289
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-923738966
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-925174886
<b>Trillian test result (tid-2160)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34484 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5483-t2160-kvm-centos7.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-923857250
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-924439100
<b>Trillian test result (tid-2150)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38981 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5483-t2150-vmware-65u2.zip
Smoke tests completed. 86 look OK, 3 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup | `Error` | 47.84 | test_affinity_groups.py
test_DeployVmAntiAffinityGroup_in_project | `Error` | 106.16 | test_affinity_groups_projects.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 39.09 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-923833705
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-923872911
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-924413278
<b>Trillian test result (tid-2149)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36999 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5483-t2149-kvm-centos7.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_hostha_enable_ha_when_host_disabled | `Error` | 2.66 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.86 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#discussion_r712838570
##########
File path: test/integration/smoke/test_snapshots.py
##########
@@ -302,14 +302,23 @@ def test_02_list_snapshots_with_removed_data_store(self):
self.apiclient,
vol
)
- self.virtual_machine_with_disk.detach_volume(
+ detach_vol_res = self.virtual_machine_with_disk.detach_volume(
self.apiclient,
vol
)
+ if detach_vol_res.storageid != storage.id:
+ dest_store = storage
+ else:
+ all_stores = store_pools = list_storage_pools(self.apiclient)
+ for store in all_stores:
+ if store.id != storage.id:
+ dest_store = store
Review comment:
The dest store (to which volume is migrated) here is other than the primary storage added above. It seems, the test here is migrate the detached volume to the newly added primary storage. So, possible to attach volume to primary storage other than newly added one. Otherwise, pls update the description/steps wherever applicable in the test method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-924702919
<b>Trillian Build Failed (tid-2161)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-923834134
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-923715366
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#discussion_r712838570
##########
File path: test/integration/smoke/test_snapshots.py
##########
@@ -302,14 +302,23 @@ def test_02_list_snapshots_with_removed_data_store(self):
self.apiclient,
vol
)
- self.virtual_machine_with_disk.detach_volume(
+ detach_vol_res = self.virtual_machine_with_disk.detach_volume(
self.apiclient,
vol
)
+ if detach_vol_res.storageid != storage.id:
+ dest_store = storage
+ else:
+ all_stores = store_pools = list_storage_pools(self.apiclient)
+ for store in all_stores:
+ if store.id != storage.id:
+ dest_store = store
Review comment:
The dest store (to which volume is migrated) here is other than the primary storage added above. It seems, the test here is migrate the detached volume to the newly added primary storage. So, possible to attach volume to primary storage other than newly added one. Otherwise, pls update the description in the test method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-923714848
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#discussion_r712893095
##########
File path: test/integration/smoke/test_snapshots.py
##########
@@ -302,14 +302,23 @@ def test_02_list_snapshots_with_removed_data_store(self):
self.apiclient,
vol
)
- self.virtual_machine_with_disk.detach_volume(
+ detach_vol_res = self.virtual_machine_with_disk.detach_volume(
self.apiclient,
vol
)
+ if detach_vol_res.storageid != storage.id:
+ dest_store = storage
+ else:
+ all_stores = store_pools = list_storage_pools(self.apiclient)
+ for store in all_stores:
+ if store.id != storage.id:
+ dest_store = store
Review comment:
Thanks @sureshanaparti - you are right, I've refactored it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-924442289
<b>Trillian test result (tid-2148)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39680 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5483-t2148-xenserver-71.zip
Smoke tests completed. 87 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 92.94 | test_kubernetes_clusters.py
test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 306.17 | test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 306.14 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.27 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#discussion_r714628413
##########
File path: test/integration/smoke/test_snapshots.py
##########
@@ -245,23 +245,30 @@ def test_02_list_snapshots_with_removed_data_store(self):
PASS,
"Invalid response returned for list volumes")
vol_uuid = vol_res[0].id
-
- # Create new Primary Storage
clusters = list_clusters(
self.apiclient,
zoneid=self.zone.id
)
assert isinstance(clusters,list) and len(clusters)>0
+ self.cleanup.append(self.virtual_machine_with_disk)
Review comment:
this is not created here. I applaud the move , but should't it be registered for cleanup right after creation to prevent it being left if an exception occurs in the meanwhile?
also as it is created at class level it should go in `_cleanup` and not in `cleanup`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#issuecomment-923873118
@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org