You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/18 01:11:41 UTC
[GitHub] [apisix] imjoey opened a new pull request #4844: ci: add workflow to build and verify apisix on CentOS 8
imjoey opened a new pull request #4844:
URL: https://github.com/apache/apisix/pull/4844
Signed-off-by: imjoey <ma...@apache.org>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
This PR is going to support building and verifying apisix on CentOS 8 via CI. This would give users the confidence to install and run apisix on CentOS 8.
For the scripts to install dependencies and run test cases are the same between CentOS 7 and CentOS 8 for now. So this PR would reuse `centos7-ci.sh` within the CentOS 8 CI.
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] imjoey commented on pull request #4844: ci: add workflow to build and verify apisix on CentOS 8
Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #4844:
URL: https://github.com/apache/apisix/pull/4844#issuecomment-900762259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4844: ci: add workflow to build and verify apisix on CentOS 8
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4844:
URL: https://github.com/apache/apisix/pull/4844#discussion_r690857665
##########
File path: .github/workflows/centos8-ci.yml
##########
@@ -0,0 +1,118 @@
+name: CI Centos8
Review comment:
Can we share the code like ` .github/workflows/build.yml` instead of repeating centos7-ci?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4844: ci: add workflow to build and verify apisix on CentOS 8
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4844:
URL: https://github.com/apache/apisix/pull/4844#issuecomment-900770137
Also, to reduce CI cost, we need to run it per week or few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4844: ci: Remove non-exist dependency packages for CentOS 7
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4844:
URL: https://github.com/apache/apisix/pull/4844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] imjoey commented on a change in pull request #4844: ci: add workflow to build and verify apisix on CentOS 8
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #4844:
URL: https://github.com/apache/apisix/pull/4844#discussion_r690859472
##########
File path: .github/workflows/centos8-ci.yml
##########
@@ -0,0 +1,118 @@
+name: CI Centos8
Review comment:
@spacewander Nice catch and that would be much better for multiple operating systems and architectures. I would make a change. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] imjoey commented on pull request #4844: ci: Remove non-exist dependency packages for CentOS 7
Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #4844:
URL: https://github.com/apache/apisix/pull/4844#issuecomment-900789511
Ping @tokers @Yiyiyimu @juzhiyuan for review, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4844: ci: add workflow to build and verify apisix on CentOS 8
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4844:
URL: https://github.com/apache/apisix/pull/4844#discussion_r690857665
##########
File path: .github/workflows/centos8-ci.yml
##########
@@ -0,0 +1,118 @@
+name: CI Centos8
Review comment:
Can we share the code like ` .github/workflows/build.yml` instead of repeating centos7-ci?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4844: ci: add workflow to build and verify apisix on CentOS 8
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4844:
URL: https://github.com/apache/apisix/pull/4844#issuecomment-900770137
Also, to reduce CI cost, we need to run it per week or few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] imjoey commented on pull request #4844: ci: add workflow to build and verify apisix on CentOS 8
Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #4844:
URL: https://github.com/apache/apisix/pull/4844#issuecomment-900762259
It's ready for review. Ping @spacewander @tokers @Yiyiyimu @juzhiyuan, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] imjoey removed a comment on pull request #4844: ci: Remove non-exist dependency packages for CentOS 7
Posted by GitBox <gi...@apache.org>.
imjoey removed a comment on pull request #4844:
URL: https://github.com/apache/apisix/pull/4844#issuecomment-900762259
It's ready for review. Ping @spacewander @tokers @Yiyiyimu @juzhiyuan, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4844: ci: Remove non-exist dependency packages for CentOS 7
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4844:
URL: https://github.com/apache/apisix/pull/4844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] imjoey removed a comment on pull request #4844: ci: Remove non-exist dependency packages for CentOS 7
Posted by GitBox <gi...@apache.org>.
imjoey removed a comment on pull request #4844:
URL: https://github.com/apache/apisix/pull/4844#issuecomment-900762259
It's ready for review. Ping @spacewander @tokers @Yiyiyimu @juzhiyuan, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] imjoey commented on a change in pull request #4844: ci: add workflow to build and verify apisix on CentOS 8
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #4844:
URL: https://github.com/apache/apisix/pull/4844#discussion_r690859472
##########
File path: .github/workflows/centos8-ci.yml
##########
@@ -0,0 +1,118 @@
+name: CI Centos8
Review comment:
@spacewander Nice catch and that would be much better for multiple operating systems and architectures. I would make a change. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org