You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Hanifi Gunes <hg...@maprtech.com> on 2014/11/11 00:39:28 UTC
Review Request 27844: DRILL-1455: enable projection pushdown past join
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27844/
-----------------------------------------------------------
Review request for drill, Aman Sinha and Jinfeng Ni.
Bugs: DRILL-1455
https://issues.apache.org/jira/browse/DRILL-1455
Repository: drill-git
Description
-------
enable projection pushdown past join
i) refactor project past filter to remove redundant code
ii) adding unit tests for projection past join & hybrid cases like projection past filter & join
iii) disable one TestExampleQueries#testSelectStartSubQueryJoinWithWhereClause until DRILL-1680 is fixed.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConditions.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastFilterRule.java dcec68a
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastJoinRule.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 7af541a
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 9eaa20e
exec/java-exec/src/test/java/org/apache/drill/TestProjectPushDown.java 828ffe9
exec/java-exec/src/test/resources/project/pushdown/empty0.json PRE-CREATION
exec/java-exec/src/test/resources/project/pushdown/empty1.json PRE-CREATION
exec/java-exec/src/test/resources/project/pushdown/empty2.json PRE-CREATION
Diff: https://reviews.apache.org/r/27844/diff/
Testing
-------
Passes tests.
Thanks,
Hanifi Gunes
Re: Review Request 27844: DRILL-1455: enable projection pushdown past
join
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27844/#review60716
-----------------------------------------------------------
Ship it!
Minor comment below; otherwise looks ok to me.
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java
<https://reviews.apache.org/r/27844/#comment102095>
Can you move this comment to the @Ignore("your comment").
exec/java-exec/src/test/java/org/apache/drill/TestProjectPushDown.java
<https://reviews.apache.org/r/27844/#comment102096>
Same as above.
exec/java-exec/src/test/java/org/apache/drill/TestProjectPushDown.java
<https://reviews.apache.org/r/27844/#comment102097>
Same as above.
- Aman Sinha
On Nov. 10, 2014, 11:39 p.m., Hanifi Gunes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27844/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 11:39 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-1455
> https://issues.apache.org/jira/browse/DRILL-1455
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> enable projection pushdown past join
>
> i) refactor project past filter to remove redundant code
> ii) adding unit tests for projection past join & hybrid cases like projection past filter & join
> iii) disable one TestExampleQueries#testSelectStartSubQueryJoinWithWhereClause until DRILL-1680 is fixed.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConditions.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastFilterRule.java dcec68a
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastJoinRule.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 7af541a
> exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 9eaa20e
> exec/java-exec/src/test/java/org/apache/drill/TestProjectPushDown.java 828ffe9
> exec/java-exec/src/test/resources/project/pushdown/empty0.json PRE-CREATION
> exec/java-exec/src/test/resources/project/pushdown/empty1.json PRE-CREATION
> exec/java-exec/src/test/resources/project/pushdown/empty2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27844/diff/
>
>
> Testing
> -------
>
> Passes tests.
>
>
> Thanks,
>
> Hanifi Gunes
>
>
Re: Review Request 27844: DRILL-1455: enable projection pushdown past
join
Posted by Jinfeng Ni <jn...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27844/#review60724
-----------------------------------------------------------
Ship it!
Ship It!
- Jinfeng Ni
On Nov. 10, 2014, 4:25 p.m., Hanifi Gunes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27844/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 4:25 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-1455
> https://issues.apache.org/jira/browse/DRILL-1455
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> enable projection pushdown past join
>
> i) refactor project past filter to remove redundant code
> ii) adding unit tests for projection past join & hybrid cases like projection past filter & join
> iii) disable one TestExampleQueries#testSelectStartSubQueryJoinWithWhereClause until DRILL-1680 is fixed.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConditions.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastFilterRule.java dcec68a
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastJoinRule.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 7af541a
> exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 9eaa20e
> exec/java-exec/src/test/java/org/apache/drill/TestProjectPushDown.java 828ffe9
> exec/java-exec/src/test/resources/project/pushdown/empty0.json PRE-CREATION
> exec/java-exec/src/test/resources/project/pushdown/empty1.json PRE-CREATION
> exec/java-exec/src/test/resources/project/pushdown/empty2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27844/diff/
>
>
> Testing
> -------
>
> Passes tests.
>
>
> Thanks,
>
> Hanifi Gunes
>
>
Re: Review Request 27844: DRILL-1455: enable projection pushdown past
join
Posted by Hanifi Gunes <hg...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27844/
-----------------------------------------------------------
(Updated Nov. 11, 2014, 12:25 a.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
Addressed comments
Bugs: DRILL-1455
https://issues.apache.org/jira/browse/DRILL-1455
Repository: drill-git
Description
-------
enable projection pushdown past join
i) refactor project past filter to remove redundant code
ii) adding unit tests for projection past join & hybrid cases like projection past filter & join
iii) disable one TestExampleQueries#testSelectStartSubQueryJoinWithWhereClause until DRILL-1680 is fixed.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConditions.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastFilterRule.java dcec68a
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastJoinRule.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 7af541a
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 9eaa20e
exec/java-exec/src/test/java/org/apache/drill/TestProjectPushDown.java 828ffe9
exec/java-exec/src/test/resources/project/pushdown/empty0.json PRE-CREATION
exec/java-exec/src/test/resources/project/pushdown/empty1.json PRE-CREATION
exec/java-exec/src/test/resources/project/pushdown/empty2.json PRE-CREATION
Diff: https://reviews.apache.org/r/27844/diff/
Testing
-------
Passes tests.
Thanks,
Hanifi Gunes