You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/12 00:57:07 UTC
[GitHub] [superset] alderson59 opened a new issue #15632: Implicit Datasource Access for Dashboard RBAC
alderson59 opened a new issue #15632:
URL: https://github.com/apache/superset/issues/15632
Hi all, I have done some reading on Dashboard Access Control and I can conclude from what I gather, that Dashboard access can now be automatically added to roles based on what you set in the UI, courtesy of https://github.com/apache/superset/pull/12680
It is noted that [SIP-51] is closed via https://github.com/apache/superset/pull/12680, addressing half of the issue.
However, this does not yet address the datasource/dataset access control with respect to Dashboard Access. I found this comment by @amitmiran137
https://github.com/apache/superset/pull/12680#issuecomment-770337622
> we plan in a follow-up PR that user will be given temporary read access to all of the datasets within a dashboard as was mentioned in the development milestones in #10408
Is there an issue/PR for this yet? Please point me to it if there is already one! :)
Use Case:
- Create a user role that has read-only access to dashboards, without access to the individual records in the underlying data (i.e. nothing shows up on Datasets menu)
- Successful implementation would look like this: a user role could be set to have ONLY access to Dashboards, and not any datasets in the menu, yet dashboard is still able to render charts without permission errors.
- This limits the user to accessing only what is set up for them via the Dashboard.
- Filtering access should still be available.
As mentioned in https://github.com/apache/superset/issues/10408#issue-664324346
> Airbnb and probably other orgs are fully dependent on dataset level access - they would not handle an extra dashboard level permission
> In our org we will have hundreds of dashboards that will be based on the same dataset
> Therefore there is no way to manage dashboard access for specific dashboards for specific users
Related issues:
[SIP-51]: https://github.com/apache/superset/issues/10408
https://github.com/apache/superset/issues/11198
https://github.com/apache/superset/issues/12910
https://github.com/apache/superset/issues/1799
https://github.com/apache/superset/issues/4127
https://github.com/apache/superset/issues/14260
etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on issue #15632: Implicit Datasource Access for Dashboard RBAC
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on issue #15632:
URL: https://github.com/apache/superset/issues/15632#issuecomment-877953878
Yes , this is implemented as mentioned here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 edited a comment on issue #15632: Implicit Datasource Access for Dashboard RBAC
Posted by GitBox <gi...@apache.org>.
amitmiran137 edited a comment on issue #15632:
URL: https://github.com/apache/superset/issues/15632#issuecomment-877953878
Yes , this is implemented as mentioned here
Just try out the DASHBOARD_RBAC feature flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MM-Lehmann commented on issue #15632: Implicit Datasource Access for Dashboard RBAC
Posted by GitBox <gi...@apache.org>.
MM-Lehmann commented on issue #15632:
URL: https://github.com/apache/superset/issues/15632#issuecomment-1062997728
Unfortunately, this feature breaks my dataset-based access. I can either use dashboard level OR dataset level. I've ran a db upgrade after setting the FF as well. What went wrong? (I am on 1.4.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alderson59 closed issue #15632: Implicit Datasource Access for Dashboard RBAC
Posted by GitBox <gi...@apache.org>.
alderson59 closed issue #15632:
URL: https://github.com/apache/superset/issues/15632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alderson59 edited a comment on issue #15632: Implicit Datasource Access for Dashboard RBAC
Posted by GitBox <gi...@apache.org>.
alderson59 edited a comment on issue #15632:
URL: https://github.com/apache/superset/issues/15632#issuecomment-877965956
Thank you, that works like a charm! Before I close, can I ask where is the best source of documentation for superset? I'd prefer referring to that in future, instead of trawling through the issue section or opening a ticket here unnecessarily :)
Can this `DASHBOARD_RBAC` feature flag (and others like these) be found here: https://superset.apache.org/docs/intro ? I wasn't able to locate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #15632: Implicit Datasource Access for Dashboard RBAC
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #15632:
URL: https://github.com/apache/superset/issues/15632#issuecomment-877897932
Pretty sure this is implemented already. Have you tried enabling the feature flag `DASHBOARD_RBAC`?
https://github.com/apache/superset/pull/13992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alderson59 edited a comment on issue #15632: Implicit Datasource Access for Dashboard RBAC
Posted by GitBox <gi...@apache.org>.
alderson59 edited a comment on issue #15632:
URL: https://github.com/apache/superset/issues/15632#issuecomment-877965956
Thank you, that works like a charm!
Also, what are the minimum required permissions for this to work without the access to explore other datasets or edit the charts? Tried Gamma, but that's more perms than needed.
Before I close, can I ask where is the best, latest source of documentation for superset? I'd prefer referring to that in future, instead of trawling through the issue section or opening a ticket here unnecessarily :)
Can this `DASHBOARD_RBAC` feature flag (and others like these) be found here: https://superset.apache.org/docs/intro ? I wasn't able to locate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alderson59 commented on issue #15632: Implicit Datasource Access for Dashboard RBAC
Posted by GitBox <gi...@apache.org>.
alderson59 commented on issue #15632:
URL: https://github.com/apache/superset/issues/15632#issuecomment-877965956
Thank you, that works like a charm! Before I close, can I ask where is the best source of documentation for superset? I'd prefer referring to that instead of trawling through the issue section or opening a ticket here unnecessarily :)
Can this `DASHBOARD_RBAC` feature flag be found here: https://superset.apache.org/docs/intro ? I wasn't able to locate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #15632: Implicit Datasource Access for Dashboard RBAC
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #15632:
URL: https://github.com/apache/superset/issues/15632#issuecomment-877898391
You can find all the PRs related to this feature here: https://github.com/apache/superset/pulls?q=is%3Apr++dashboard_rbac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #15632: Implicit Datasource Access for Dashboard RBAC
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #15632:
URL: https://github.com/apache/superset/issues/15632#issuecomment-877991619
Documentation for this feature can be found here: https://superset.apache.org/docs/creating-charts-dashboards/first-dashboard#manage-access-to-dashboards
info about the various feature flags can be found here: https://github.com/apache/superset/blob/master/RESOURCES/FEATURE_FLAGS.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alderson59 edited a comment on issue #15632: Implicit Datasource Access for Dashboard RBAC
Posted by GitBox <gi...@apache.org>.
alderson59 edited a comment on issue #15632:
URL: https://github.com/apache/superset/issues/15632#issuecomment-877965956
Thank you, that works like a charm! Before I close, can I ask where is the best, latest source of documentation for superset? I'd prefer referring to that in future, instead of trawling through the issue section or opening a ticket here unnecessarily :)
Can this `DASHBOARD_RBAC` feature flag (and others like these) be found here: https://superset.apache.org/docs/intro ? I wasn't able to locate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org