[jira] [Commented] (IGNITE-6745) Java 9: rework usages of URLClassLoader.getURLs()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234985#comment-16234985 ] 

ASF GitHub Bot commented on IGNITE-6745:
----------------------------------------

GitHub user elcergey opened a pull request:

    https://github.com/apache/ignite/pull/2970

    IGNITE-6745: Java 9: rework usages of URLClassLoader.getURLs()

    Regarding the https://issues.apache.org/jira/browse/IGNITE-6745

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/elcergey/ignite master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2970.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2970
    
----
commit 31aae683b37c4feeddaba3100e46526e3d1f019d
Author: cossack5@mail.ru <co...@mail.ru>
Date:   2017-11-01T23:51:04Z

    IGNITE-6745: Java 9: rework usages of URLClassLoader.getURLs()

----


> Java 9: rework usages of URLClassLoader.getURLs()
> -------------------------------------------------
>
>                 Key: IGNITE-6745
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6745
>             Project: Ignite
>          Issue Type: Task
>      Security Level: Public(Viewable by anyone) 
>          Components: general
>            Reporter: Vladimir Ozerov
>            Priority: Major
>             Fix For: 2.4
>
>         Attachments: IGNITE-6745.patch
>
>
> We use this method in multiple places:
> 1) {{MessageCodeGenerator}}
> 2) {{BinaryContext}}
> 3) {{ClassesGenerator}}
> 4) {{GridUriDeploymentFileProcessor}}
> The problem is that in Java 9 application class loader is not {{URLClassLoader}}, so we cannot get URLs easily. Instead typically it is {{BuiltinClassLoader}}, which refers to {{URLClassLoader}} in it's internal field {{ucp}}.
> Let's refactor all usages of {{URLClassLoader.getURLs}} to some utility method, which will be able to handle both Java 7/8 and Java 9 (through reflection).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)