You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/03/08 03:52:33 UTC
Review Request 65968: Updated the master's decline handler to take an
rvalue reference.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65968/
-----------------------------------------------------------
Review request for mesos and Meng Zhu.
Bugs: MESOS-8628
https://issues.apache.org/jira/browse/MESOS-8628
Repository: mesos
Description
-------
The master's handlers should all take rvalue references for
consistency.
Diffs
-----
src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad
src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb
src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35
Diff: https://reviews.apache.org/r/65968/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 65968: Updated the master's decline handler to
take an rvalue reference.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65968/#review198856
-----------------------------------------------------------
PASS: Mesos patch 65968 was successfully built and tested.
Reviews applied: `['65964', '65965', '65966', '65967', '65968']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65968
- Mesos Reviewbot Windows
On March 8, 2018, 3:52 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65968/
> -----------------------------------------------------------
>
> (Updated March 8, 2018, 3:52 a.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The master's handlers should all take rvalue references for
> consistency.
>
>
> Diffs
> -----
>
> src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad
> src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb
> src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35
>
>
> Diff: https://reviews.apache.org/r/65968/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 65968: Updated the master's decline handler to
take an rvalue reference.
Posted by Benjamin Mahler <bm...@apache.org>.
> On March 8, 2018, 8:54 p.m., Meng Zhu wrote:
> > Adding a TODO to make other handlers also take rvalue?
Rather than adding TODOs on each handler, I tracked the work under MESOS-8628.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65968/#review198910
-----------------------------------------------------------
On March 8, 2018, 3:52 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65968/
> -----------------------------------------------------------
>
> (Updated March 8, 2018, 3:52 a.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The master's handlers should all take rvalue references for
> consistency.
>
>
> Diffs
> -----
>
> src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad
> src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb
> src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35
>
>
> Diff: https://reviews.apache.org/r/65968/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 65968: Updated the master's decline handler to
take an rvalue reference.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65968/#review198910
-----------------------------------------------------------
Ship it!
Adding a TODO to make other handlers also take rvalue?
- Meng Zhu
On March 7, 2018, 7:52 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65968/
> -----------------------------------------------------------
>
> (Updated March 7, 2018, 7:52 p.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The master's handlers should all take rvalue references for
> consistency.
>
>
> Diffs
> -----
>
> src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad
> src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb
> src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35
>
>
> Diff: https://reviews.apache.org/r/65968/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>