You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/07 14:43:54 UTC

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

avijayanhwx commented on a change in pull request #1289:
URL: https://github.com/apache/hadoop-ozone/pull/1289#discussion_r467085725



##########
File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto
##########
@@ -43,14 +43,22 @@ message DatanodeDetailsProto {
     // network name, can be Ip address or host name, depends
     optional string networkName = 6;
     optional string networkLocation = 7; // Network topology location
-    optional string version = 8;         // Datanode version

Review comment:
       @runitao Can we mark these fields as 'deprecated', and not set them in the code, rather than removing them. This will likely backward compatibility when we have a case to add a new field in the future.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org