You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Stefan Fußenegger (JIRA)" <ji...@apache.org> on 2008/02/21 19:53:19 UTC

[jira] Created: (WICKET-1363) Support RestartResponseAtInterceptPageException/continueToOriginalDestination() with Ajax requests

Support RestartResponseAtInterceptPageException/continueToOriginalDestination() with Ajax requests
--------------------------------------------------------------------------------------------------

                 Key: WICKET-1363
                 URL: https://issues.apache.org/jira/browse/WICKET-1363
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.3.1
            Reporter: Stefan Fußenegger
            Priority: Minor


While RestartResponseAtInterceptPageException already works correctly with Ajax requests (e.g. user is redirected to a login page), continueToOriginalDestination() forwards the user to the Ajax request URL (user will get a <ajax-respons>...</ajax-response> on his screen)

Improvement: The user should rather be forwarded to a proper page. 

Workaround: A custom PageMap implementation
However, as the method setUpRedirect(RequestCycle) is private, deriving from the default PageMap will require some ugly copy-paste in order to do so. This could be avoided by a) making setUpRedirect(RequestCycle) protected and/or b) introduce a protected method that constructs the interceptContinuationURL inside setUpRedirect(RequestCycle).

The custom behaviour could be: Redirect to the page the Ajax request belonged to. Or even better: redirect to the Ajax call and render the complete page (well, don't know how tricky that would be). 

see also: http://www.nabble.com/RestartResponseAtInterceptPageException-with-Ajax-td15607225.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (WICKET-1363) Support RestartResponseAtInterceptPageException/continueToOriginalDestination() with Ajax requests

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-1363.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.2
         Assignee: Johan Compagner

i just test in the setupRedirect of PageMap if it is an ajax request
if it is then the intercept url will be that of the ajax request page instead of the ajax url.

> Support RestartResponseAtInterceptPageException/continueToOriginalDestination() with Ajax requests
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1363
>                 URL: https://issues.apache.org/jira/browse/WICKET-1363
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.1
>            Reporter: Stefan Fußenegger
>            Assignee: Johan Compagner
>            Priority: Minor
>             Fix For: 1.3.2
>
>
> While RestartResponseAtInterceptPageException already works correctly with Ajax requests (e.g. user is redirected to a login page), continueToOriginalDestination() forwards the user to the Ajax request URL (user will get a <ajax-respons>...</ajax-response> on his screen)
> Improvement: The user should rather be forwarded to a proper page. 
> Workaround: A custom PageMap implementation
> However, as the method setUpRedirect(RequestCycle) is private, deriving from the default PageMap will require some ugly copy-paste in order to do so. This could be avoided by a) making setUpRedirect(RequestCycle) protected and/or b) introduce a protected method that constructs the interceptContinuationURL inside setUpRedirect(RequestCycle).
> The custom behaviour could be: Redirect to the page the Ajax request belonged to. Or even better: redirect to the Ajax call and render the complete page (well, don't know how tricky that would be). 
> see also: http://www.nabble.com/RestartResponseAtInterceptPageException-with-Ajax-td15607225.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.