You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "mvisani (via GitHub)" <gi...@apache.org> on 2026/09/28 06:47:25 UTC
[PR] Fix `Display` of quoted identifiers with a backslash before the quote [datafusion-sqlparser-rs]
mvisani opened a new pull request, #2593:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2593
The tokenizer never treated a backslash as an escape inside a quoted identifier, but `EscapeQuotedString` assumed a quote after a backslash was already escaped. The rendered SQL was then unterminated, e.g. `SELECT "a\"""` displayed as `SELECT "a\""` and failed to re-parse. Found by fuzzing `fuzz_parse_roundtrip`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `Display` of quoted identifiers with a backslash before the quote [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2593:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2593#issuecomment-6134170724
FYI, the fuzzer crash is not caused by your code, just the seed you added facilitated the fuzzer in finding it. Can you please rebase the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `Display` of quoted identifiers with a backslash before the quote [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2593:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2593#issuecomment-5865430093
@mvisani add to the fuzzer seed corpus the crashing case, so it will be faster to get to next time around
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `Display` of quoted identifiers with a backslash before the quote [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2593:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2593#issuecomment-5865465742
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2593?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.10%. Comparing base ([`560a13c`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/560a13c32b6c3b9f1a202d6b9a9020c016bbf7be?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6e23a7b`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/6e23a7bdfe36d90b3e769b056fb2ec089881095a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2593 +/- ##
=======================================
Coverage 81.09% 81.10%
=======================================
Files 42 42
Lines 33684 33695 +11
Branches 33684 33695 +11
=======================================
+ Hits 27316 27327 +11
Misses 2798 2798
Partials 3570 3570
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2593?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `Display` of quoted identifiers with a backslash before the quote [datafusion-sqlparser-rs]
Posted by "mvisani (via GitHub)" <gi...@apache.org>.
mvisani commented on PR #2593:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2593#issuecomment-6139929451
@LucaCappelletti94 Should be done !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `Display` of quoted identifiers with a backslash before the quote [datafusion-sqlparser-rs]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2593:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2593#issuecomment-5864897964
<!-- dialect-labeler -->
No dialect label was applied because the title does not name a SQL dialect.
If this change targets one or more dialects, edit the title to `<Dialect>[, <Dialect>]: <description>`, add a `Dialects: <Dialect>[, <Dialect>]` line to the description, or reply with one. Reply `Dialects: none` if the change is dialect-agnostic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org