You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "smiklosovic (via GitHub)" <gi...@apache.org> on 2024/03/13 10:17:29 UTC

Re: [PR] CASSANDRA-14572 Add system_metrics keyspace to default keyspaces list [cassandra-dtest]

smiklosovic commented on code in PR #249:
URL: https://github.com/apache/cassandra-dtest/pull/249#discussion_r1522938965


##########
cqlsh_tests/test_cqlsh.py:
##########
@@ -1040,7 +1040,7 @@ def test_default_keyspaces_exist(self):
         node1, = self.cluster.nodelist()
 
         # Describe keyspaces
-        expected_keyspaces = ['system_schema', 'system', 'system_traces', 'system_views',
+        expected_keyspaces = ['system_schema', 'system', 'system_traces', 'system_views', 'system_metrics',

Review Comment:
   @Mmuzaf this will not work because system_metrics will be only on trunk and this test will be executed for 4.0+ so whey 4.0 will be built, this one will not be there. You need to do it like below for system_cluster_metadata case:
   
           if self.cluster.version() >= LooseVersion('5.1'):
               expected_keyspaces.append('system_metrics')
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org