You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sentry.apache.org by Xinran Tinney <yu...@gmail.com> on 2018/04/16 16:31:28 UTC

Review Request 66636: SENTRY-2200 Update Sentry datanucleus config names

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66636/
-----------------------------------------------------------

Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar kalvagadda, Na Li, Steve Moist, Sergio Pena, Vadim Spector, and Xinran Tinney.


Repository: sentry


Description
-------

Since 2.0, the datanucleus version in Sentry changed from 3.2 to 4.1.

Based on the datanucleus documentation following config names are renamed. Sentry has several places use those configuration names. We should update the config names to reflect the correct names.

Migration from 3.3.7 to 4.0.0.M1
Migrating will require the following changes

Persistence property datanucleus.allowAttachOfTransient now defaults to true for JPA usage; set it explicitly to get old behaviour
Persistence property datanucleus.metadata.validate was removed (replaced by datanucleus.metadata.xml.validate some time back)
Persistence property datanucleus.defaultInheritanceStrategy is renamed to datanucleus.metadata.defaultInheritanceStrategy
Persistence property datanucleus.autoCreateSchema is renamed to datanucleus.schema.autoCreateAll
Persistence property datanucleus.autoCreateTables is renamed to datanucleus.schema.autoCreateTables
Persistence property datanucleus.autoCreateColumns is renamed to datanucleus.schema.autoCreateColumns
Persistence property datanucleus.autoCreateConstraints is renamed to datanucleus.schema.autoCreateConstraints
Persistence property datanucleus.validateSchema is renamed to datanucleus.schema.validateAll
Persistence property datanucleus.validateTables is renamed to datanucleus.schema.validateTables
Persistence property datanucleus.validateColumns is renamed to datanucleus.schema.validateColumns
Persistence property datanucleus.validateConstraints is renamed to datanucleus.schema.validateConstraints
Persistence property datanucleus.fixedDatastore is now removed, since it only equated to setting the "autoCreate" properties to false.


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 83c0fc47 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 7e02874b 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryRole.java 61a74c3f 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 9b0aeb2f 


Diff: https://reviews.apache.org/r/66636/diff/1/


Testing
-------

mvn clean install all SUCCESS


Thanks,

Xinran Tinney

Re: Review Request 66636: SENTRY-2200 Update Sentry datanucleus config names

Posted by Na Li via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66636/#review201324
-----------------------------------------------------------


Ship it!




Ship It!

- Na Li


On April 16, 2018, 4:31 p.m., Xinran Tinney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66636/
> -----------------------------------------------------------
> 
> (Updated April 16, 2018, 4:31 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar kalvagadda, Na Li, Steve Moist, Sergio Pena, Vadim Spector, and Xinran Tinney.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Since 2.0, the datanucleus version in Sentry changed from 3.2 to 4.1.
> 
> Based on the datanucleus documentation following config names are renamed. Sentry has several places use those configuration names. We should update the config names to reflect the correct names.
> 
> Migration from 3.3.7 to 4.0.0.M1
> Migrating will require the following changes
> 
> Persistence property datanucleus.allowAttachOfTransient now defaults to true for JPA usage; set it explicitly to get old behaviour
> Persistence property datanucleus.metadata.validate was removed (replaced by datanucleus.metadata.xml.validate some time back)
> Persistence property datanucleus.defaultInheritanceStrategy is renamed to datanucleus.metadata.defaultInheritanceStrategy
> Persistence property datanucleus.autoCreateSchema is renamed to datanucleus.schema.autoCreateAll
> Persistence property datanucleus.autoCreateTables is renamed to datanucleus.schema.autoCreateTables
> Persistence property datanucleus.autoCreateColumns is renamed to datanucleus.schema.autoCreateColumns
> Persistence property datanucleus.autoCreateConstraints is renamed to datanucleus.schema.autoCreateConstraints
> Persistence property datanucleus.validateSchema is renamed to datanucleus.schema.validateAll
> Persistence property datanucleus.validateTables is renamed to datanucleus.schema.validateTables
> Persistence property datanucleus.validateColumns is renamed to datanucleus.schema.validateColumns
> Persistence property datanucleus.validateConstraints is renamed to datanucleus.schema.validateConstraints
> Persistence property datanucleus.fixedDatastore is now removed, since it only equated to setting the "autoCreate" properties to false.
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 83c0fc47 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 7e02874b 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryRole.java 61a74c3f 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 9b0aeb2f 
> 
> 
> Diff: https://reviews.apache.org/r/66636/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean install all SUCCESS
> 
> 
> Thanks,
> 
> Xinran Tinney
> 
>

Re: Review Request 66636: SENTRY-2200 Update Sentry datanucleus config names

Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66636/#review201315
-----------------------------------------------------------


Ship it!




It looks good, thanks for the patch.

- Sergio Pena


On April 16, 2018, 4:31 p.m., Xinran Tinney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66636/
> -----------------------------------------------------------
> 
> (Updated April 16, 2018, 4:31 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar kalvagadda, Na Li, Steve Moist, Sergio Pena, Vadim Spector, and Xinran Tinney.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Since 2.0, the datanucleus version in Sentry changed from 3.2 to 4.1.
> 
> Based on the datanucleus documentation following config names are renamed. Sentry has several places use those configuration names. We should update the config names to reflect the correct names.
> 
> Migration from 3.3.7 to 4.0.0.M1
> Migrating will require the following changes
> 
> Persistence property datanucleus.allowAttachOfTransient now defaults to true for JPA usage; set it explicitly to get old behaviour
> Persistence property datanucleus.metadata.validate was removed (replaced by datanucleus.metadata.xml.validate some time back)
> Persistence property datanucleus.defaultInheritanceStrategy is renamed to datanucleus.metadata.defaultInheritanceStrategy
> Persistence property datanucleus.autoCreateSchema is renamed to datanucleus.schema.autoCreateAll
> Persistence property datanucleus.autoCreateTables is renamed to datanucleus.schema.autoCreateTables
> Persistence property datanucleus.autoCreateColumns is renamed to datanucleus.schema.autoCreateColumns
> Persistence property datanucleus.autoCreateConstraints is renamed to datanucleus.schema.autoCreateConstraints
> Persistence property datanucleus.validateSchema is renamed to datanucleus.schema.validateAll
> Persistence property datanucleus.validateTables is renamed to datanucleus.schema.validateTables
> Persistence property datanucleus.validateColumns is renamed to datanucleus.schema.validateColumns
> Persistence property datanucleus.validateConstraints is renamed to datanucleus.schema.validateConstraints
> Persistence property datanucleus.fixedDatastore is now removed, since it only equated to setting the "autoCreate" properties to false.
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 83c0fc47 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 7e02874b 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryRole.java 61a74c3f 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 9b0aeb2f 
> 
> 
> Diff: https://reviews.apache.org/r/66636/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean install all SUCCESS
> 
> 
> Thanks,
> 
> Xinran Tinney
> 
>