[GitHub] [kafka] runningcode commented on a change in pull request #10490: MINOR: Gradle build optimizations

[GitBox <gi...@apache.org>]

runningcode commented on a change in pull request #10490:
URL: https://github.com/apache/kafka/pull/10490#discussion_r608389913



##########
File path: build.gradle
##########
@@ -1148,8 +1155,10 @@ project(':clients') {
 
   task createVersionFile(dependsOn: determineCommitId) {
     ext.receiptFile = file("$buildDir/kafka/$buildVersionFileName")
+    inputs.property('commitId', commitId)
+    inputs.property('version', version)
     outputs.file receiptFile
-    outputs.upToDateWhen { false }
+    outputs.cacheIf { true }

Review comment:
       Since this file is rather small and easy to create. It might make sense to _not_ enable the build cache for this task since the ziping and unzipping of this cache entry might take longer than it would take to write this file directly.

##########
File path: settings.gradle
##########
@@ -49,3 +51,9 @@ include 'clients',
     'streams:upgrade-system-tests-26',
     'streams:upgrade-system-tests-27',
     'tools'
+
+buildCache {

Review comment:
       This `buildCache` block is optional and can be removed.`org.gradle.caching=true` sets up the local build cache by default with the remote build cache disabled.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org