You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/06/20 09:34:29 UTC
[jira] Created: (HARMONY-623) java.net.ServerSocket constrcutor
should not throw IOException if "socksProxyHost" property is set.
java.net.ServerSocket constrcutor should not throw IOException if "socksProxyHost" property is set.
---------------------------------------------------------------------------------------------------
Key: HARMONY-623
URL: http://issues.apache.org/jira/browse/HARMONY-623
Project: Harmony
Type: Bug
Components: Classlib
Reporter: Andrew Zhang
Priority: Minor
Harmony java.net.ServerSocket constrcutor throws IOException if "socksProxyHost" property is set while RI doesn't.
Following test reproduces the bug.
public void test_ConstructorI_SocksSet() throws IOException {
ServerSocket ss = null;
Properties props = (Properties) System.getProperties().clone();
try {
System.setProperty("socksProxyHost", "127.0.0.1");
System.setProperty("socksProxyPort", "12345");
ss = new ServerSocket(Support_PortManager.getNextPort());
} finally {
System.setProperties(props);
if (null != ss) {
ss.close();
}
}
}
Test result:
RI passes but Harmony fails.
I'll try to fix the problem. Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-623) java.net.ServerSocket constrcutor
should not throw IOException if "socksProxyHost" property is set.
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-623?page=all ]
George Harley resolved HARMONY-623:
-----------------------------------
Resolution: Fixed
Hi Andrew,
Patch committed in revision 416373. Please could you check that it has been applied as expected.
Thank you very much for this enhancement.
Best regards,
George
> java.net.ServerSocket constrcutor should not throw IOException if "socksProxyHost" property is set.
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-623
> URL: http://issues.apache.org/jira/browse/HARMONY-623
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: luni.src.diff
>
> Harmony java.net.ServerSocket constrcutor throws IOException if "socksProxyHost" property is set while RI doesn't.
> Following test reproduces the bug.
> public void test_ConstructorI_SocksSet() throws IOException {
> ServerSocket ss = null;
> Properties props = (Properties) System.getProperties().clone();
> try {
> System.setProperty("socksProxyHost", "127.0.0.1");
> System.setProperty("socksProxyPort", "12345");
> ss = new ServerSocket(Support_PortManager.getNextPort());
> } finally {
> System.setProperties(props);
> if (null != ss) {
> ss.close();
> }
> }
> }
> Test result:
> RI passes but Harmony fails.
> I'll try to fix the problem. Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-623) java.net.ServerSocket constrcutor
should not throw IOException if "socksProxyHost" property is set.
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-623?page=all ]
George Harley reassigned HARMONY-623:
-------------------------------------
Assign To: George Harley
> java.net.ServerSocket constrcutor should not throw IOException if "socksProxyHost" property is set.
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-623
> URL: http://issues.apache.org/jira/browse/HARMONY-623
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: luni.src.diff
>
> Harmony java.net.ServerSocket constrcutor throws IOException if "socksProxyHost" property is set while RI doesn't.
> Following test reproduces the bug.
> public void test_ConstructorI_SocksSet() throws IOException {
> ServerSocket ss = null;
> Properties props = (Properties) System.getProperties().clone();
> try {
> System.setProperty("socksProxyHost", "127.0.0.1");
> System.setProperty("socksProxyPort", "12345");
> ss = new ServerSocket(Support_PortManager.getNextPort());
> } finally {
> System.setProperties(props);
> if (null != ss) {
> ss.close();
> }
> }
> }
> Test result:
> RI passes but Harmony fails.
> I'll try to fix the problem. Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-623) java.net.ServerSocket constrcutor
should not throw IOException if "socksProxyHost" property is set.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-623?page=all ]
Andrew Zhang updated HARMONY-623:
---------------------------------
Attachment: luni.src.diff
Hello,
Would you please try my patch?
Thanks!
> java.net.ServerSocket constrcutor should not throw IOException if "socksProxyHost" property is set.
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-623
> URL: http://issues.apache.org/jira/browse/HARMONY-623
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Priority: Minor
> Attachments: luni.src.diff
>
> Harmony java.net.ServerSocket constrcutor throws IOException if "socksProxyHost" property is set while RI doesn't.
> Following test reproduces the bug.
> public void test_ConstructorI_SocksSet() throws IOException {
> ServerSocket ss = null;
> Properties props = (Properties) System.getProperties().clone();
> try {
> System.setProperty("socksProxyHost", "127.0.0.1");
> System.setProperty("socksProxyPort", "12345");
> ss = new ServerSocket(Support_PortManager.getNextPort());
> } finally {
> System.setProperties(props);
> if (null != ss) {
> ss.close();
> }
> }
> }
> Test result:
> RI passes but Harmony fails.
> I'll try to fix the problem. Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-623) java.net.ServerSocket constrcutor
should not throw IOException if "socksProxyHost" property is set.
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-623?page=all ]
George Harley closed HARMONY-623:
---------------------------------
Verified by Andrew.
> java.net.ServerSocket constrcutor should not throw IOException if "socksProxyHost" property is set.
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-623
> URL: http://issues.apache.org/jira/browse/HARMONY-623
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: luni.src.diff
>
> Harmony java.net.ServerSocket constrcutor throws IOException if "socksProxyHost" property is set while RI doesn't.
> Following test reproduces the bug.
> public void test_ConstructorI_SocksSet() throws IOException {
> ServerSocket ss = null;
> Properties props = (Properties) System.getProperties().clone();
> try {
> System.setProperty("socksProxyHost", "127.0.0.1");
> System.setProperty("socksProxyPort", "12345");
> ss = new ServerSocket(Support_PortManager.getNextPort());
> } finally {
> System.setProperties(props);
> if (null != ss) {
> ss.close();
> }
> }
> }
> Test result:
> RI passes but Harmony fails.
> I'll try to fix the problem. Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-623) java.net.ServerSocket constrcutor
should not throw IOException if "socksProxyHost" property is set.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-623?page=comments#action_12417400 ]
Andrew Zhang commented on HARMONY-623:
--------------------------------------
Hello George,
The fix looks fine, many thanks!
Best regards,
Andrew
> java.net.ServerSocket constrcutor should not throw IOException if "socksProxyHost" property is set.
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-623
> URL: http://issues.apache.org/jira/browse/HARMONY-623
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: luni.src.diff
>
> Harmony java.net.ServerSocket constrcutor throws IOException if "socksProxyHost" property is set while RI doesn't.
> Following test reproduces the bug.
> public void test_ConstructorI_SocksSet() throws IOException {
> ServerSocket ss = null;
> Properties props = (Properties) System.getProperties().clone();
> try {
> System.setProperty("socksProxyHost", "127.0.0.1");
> System.setProperty("socksProxyPort", "12345");
> ss = new ServerSocket(Support_PortManager.getNextPort());
> } finally {
> System.setProperties(props);
> if (null != ss) {
> ss.close();
> }
> }
> }
> Test result:
> RI passes but Harmony fails.
> I'll try to fix the problem. Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira