You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/02/02 23:01:25 UTC
[kudu-CR] Improved logging of DMS flushes
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9204
Change subject: Improved logging of DMS flushes
......................................................................
Improved logging of DMS flushes
From compaction-test.cc's TestRowSetInput,
Before:
I0202 14:52:24.983525 2427953984 delta_tracker.cc:727] T test_tablet_id P a3e9bdf25f0b431ea57d0249535c29b3: Flushing 20 deltas from DMS 0...
I0202 14:52:24.984046 2427953984 delta_tracker.cc:668] T test_tablet_id P a3e9bdf25f0b431ea57d0249535c29b3: Flushed delta block: 0198399763226209 ts range: [11, 30]
After:
I0202 14:45:18.924826 2427953984 delta_tracker.cc:726] T test_tablet_id P 37440651650a4d858267ad408b7e1ac0: Flushing 20 deltas (1759 bytes) from DMS 0
I0202 14:45:18.925750 2427953984 delta_tracker.cc:668] T test_tablet_id P 37440651650a4d858267ad408b7e1ac0: Flushed delta block 0052242700095437 (296 bytes) stats: ts range=[11, 30], delete_count=[0], reinsert_count=[0], update_counts_by_col_id=[12:20,11:20]
Plus one tiny change to clarify logging on flushes.
Change-Id: I8241a6ae33c22838504aa7007463d11167a22e65
---
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/tablet.cc
3 files changed, 10 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/9204/1
--
To view, visit http://gerrit.cloudera.org:8080/9204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8241a6ae33c22838504aa7007463d11167a22e65
Gerrit-Change-Number: 9204
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Improved logging of DMS flushes
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9204 )
Change subject: Improved logging of DMS flushes
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8241a6ae33c22838504aa7007463d11167a22e65
Gerrit-Change-Number: 9204
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Feb 2018 01:40:34 +0000
Gerrit-HasComments: No
[kudu-CR] Improved logging of DMS flushes
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9204
to look at the new patch set (#2).
Change subject: Improved logging of DMS flushes
......................................................................
Improved logging of DMS flushes
From compaction-test.cc's TestRowSetInput,
Before:
I0202 14:52:24.983525 2427953984 delta_tracker.cc:727] T test_tablet_id P a3e9bdf25f0b431ea57d0249535c29b3: Flushing 20 deltas from DMS 0...
I0202 14:52:24.984046 2427953984 delta_tracker.cc:668] T test_tablet_id P a3e9bdf25f0b431ea57d0249535c29b3: Flushed delta block: 0198399763226209 ts range: [11, 30]
After:
I0202 14:45:18.924826 2427953984 delta_tracker.cc:726] T test_tablet_id P 37440651650a4d858267ad408b7e1ac0: Flushing 20 deltas (1759 bytes on disk) from DMS 0
I0202 14:45:18.925750 2427953984 delta_tracker.cc:668] T test_tablet_id P 37440651650a4d858267ad408b7e1ac0: Flushed delta block 0052242700095437 (296 bytes in memory) stats: ts range=[11, 30], delete_count=[0], reinsert_count=[0], update_counts_by_col_id=[12:20,11:20]
Plus one tiny change to clarify logging on flushes.
Change-Id: I8241a6ae33c22838504aa7007463d11167a22e65
---
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/tablet.cc
3 files changed, 11 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/9204/2
--
To view, visit http://gerrit.cloudera.org:8080/9204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8241a6ae33c22838504aa7007463d11167a22e65
Gerrit-Change-Number: 9204
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Improved logging of DMS flushes
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9204 )
Change subject: Improved logging of DMS flushes
......................................................................
Improved logging of DMS flushes
From compaction-test.cc's TestRowSetInput,
Before:
I0202 14:52:24.983525 2427953984 delta_tracker.cc:727] T test_tablet_id P a3e9bdf25f0b431ea57d0249535c29b3: Flushing 20 deltas from DMS 0...
I0202 14:52:24.984046 2427953984 delta_tracker.cc:668] T test_tablet_id P a3e9bdf25f0b431ea57d0249535c29b3: Flushed delta block: 0198399763226209 ts range: [11, 30]
After:
I0202 14:45:18.924826 2427953984 delta_tracker.cc:726] T test_tablet_id P 37440651650a4d858267ad408b7e1ac0: Flushing 20 deltas (1759 bytes on disk) from DMS 0
I0202 14:45:18.925750 2427953984 delta_tracker.cc:668] T test_tablet_id P 37440651650a4d858267ad408b7e1ac0: Flushed delta block 0052242700095437 (296 bytes in memory) stats: ts range=[11, 30], delete_count=[0], reinsert_count=[0], update_counts_by_col_id=[12:20,11:20]
Plus one tiny change to clarify logging on flushes.
Change-Id: I8241a6ae33c22838504aa7007463d11167a22e65
Reviewed-on: http://gerrit.cloudera.org:8080/9204
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/tablet.cc
3 files changed, 11 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8241a6ae33c22838504aa7007463d11167a22e65
Gerrit-Change-Number: 9204
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Improved logging of DMS flushes
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9204 )
Change subject: Improved logging of DMS flushes
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc
File src/kudu/tablet/delta_tracker.cc:
http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc@669
PS1, Line 669: bytes
> can you clarify this as "on disk"
Done
http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc@680
PS1, Line 680: LOG_WITH_PREFIX(INFO) << "Opened new delta block " << block_id.ToString() << " for read";
> I wonder if this log is really useful - seems somewhat redundant with the a
Done
http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc@727
PS1, Line 727: bytes
> can you clarify "in memory" here to contrast from the bytes that we report
Done
--
To view, visit http://gerrit.cloudera.org:8080/9204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8241a6ae33c22838504aa7007463d11167a22e65
Gerrit-Change-Number: 9204
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Feb 2018 08:47:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] Improved logging of DMS flushes
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9204 )
Change subject: Improved logging of DMS flushes
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc
File src/kudu/tablet/delta_tracker.cc:
http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc@669
PS1, Line 669: bytes
can you clarify this as "on disk"
http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc@680
PS1, Line 680: LOG_WITH_PREFIX(INFO) << "Opened new delta block " << block_id.ToString() << " for read";
I wonder if this log is really useful - seems somewhat redundant with the above, maybe it should be VLOG(1)?
http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc@727
PS1, Line 727: bytes
can you clarify "in memory" here to contrast from the bytes that we report on disk after the flush?
--
To view, visit http://gerrit.cloudera.org:8080/9204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8241a6ae33c22838504aa7007463d11167a22e65
Gerrit-Change-Number: 9204
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 05 Feb 2018 04:19:02 +0000
Gerrit-HasComments: Yes