You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/21 16:42:28 UTC

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request, #6680: poll: defalut set POLLERR POLLHUP to events

GUIDINGLI opened a new pull request, #6680:
URL: https://github.com/apache/incubator-nuttx/pull/6680

   
   ## Summary
   
   poll: defalut set POLLERR POLLHUP to events
   
   ## Impact
   
   poll
   
   ## Testing
   
   VELA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6680: poll: defalut set POLLERR POLLHUP to events

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6680:
URL: https://github.com/apache/incubator-nuttx/pull/6680#issuecomment-1191836121

   should we remove the special handle for POLLERR and POLLHUP now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6680: poll: defalut set POLLERR POLLHUP to events

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6680:
URL: https://github.com/apache/incubator-nuttx/pull/6680


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6680: poll: defalut set POLLERR POLLHUP to events

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6680:
URL: https://github.com/apache/incubator-nuttx/pull/6680#discussion_r928080747


##########
fs/vfs/fs_poll.c:
##########
@@ -120,6 +120,7 @@ static inline int poll_setup(FAR struct pollfd *fds, nfds_t nfds,
       fds[i].sem     = sem;
       fds[i].revents = 0;
       fds[i].priv    = NULL;
+      fds[i].events |= (POLLERR | POLLHUP);

Review Comment:
   ```suggestion
         fds[i].events |= POLLERR | POLLHUP;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org