You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/18 14:45:35 UTC
[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write
pkarashchenko opened a new pull request, #6295:
URL: https://github.com/apache/incubator-nuttx/pull/6295
## Summary
Fix sporadic bit flip after internal flash byte write
## Impact
Improve progmem write for SAMv7 based devices
## Testing
Verified with custom SAMe70 based board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko closed pull request #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko closed pull request #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write
URL: https://github.com/apache/nuttx/pull/6295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6295:
URL: https://github.com/apache/incubator-nuttx/pull/6295#discussion_r876426419
##########
arch/arm/src/samv7/sam_progmem.c:
##########
@@ -202,9 +202,9 @@ void sam_progmem_initialize(void)
{
uint32_t regval;
- /* Set flash access mode to 128bit and wait status to 4 */
+ /* Flash access mode is 128bit always so configure wait states to 6 */
- sam_eefc_initaccess(SAM_EFC_ACCESS_MODE_128, 4);
+ sam_eefc_initaccess(6);
Review Comment:
Done. Thank you @acassis for your comment. It lead me to re-evaluate solution and make a better fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6295:
URL: https://github.com/apache/incubator-nuttx/pull/6295#discussion_r876426419
##########
arch/arm/src/samv7/sam_progmem.c:
##########
@@ -202,9 +202,9 @@ void sam_progmem_initialize(void)
{
uint32_t regval;
- /* Set flash access mode to 128bit and wait status to 4 */
+ /* Flash access mode is 128bit always so configure wait states to 6 */
- sam_eefc_initaccess(SAM_EFC_ACCESS_MODE_128, 4);
+ sam_eefc_initaccess(6);
Review Comment:
Done. Thank you @acassis for your comment. It lead me to re-evaluate solution and make a better fix.
I'm marking PR as WIP for now because want to perform more tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6295:
URL: https://github.com/apache/incubator-nuttx/pull/6295#discussion_r876030507
##########
arch/arm/src/samv7/sam_progmem.c:
##########
@@ -202,9 +202,9 @@ void sam_progmem_initialize(void)
{
uint32_t regval;
- /* Set flash access mode to 128bit and wait status to 4 */
+ /* Flash access mode is 128bit always so configure wait states to 6 */
- sam_eefc_initaccess(SAM_EFC_ACCESS_MODE_128, 4);
+ sam_eefc_initaccess(6);
Review Comment:
Ok. I will add this to Kconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #6295:
URL: https://github.com/apache/incubator-nuttx/pull/6295#discussion_r875999235
##########
arch/arm/src/samv7/sam_progmem.c:
##########
@@ -202,9 +202,9 @@ void sam_progmem_initialize(void)
{
uint32_t regval;
- /* Set flash access mode to 128bit and wait status to 4 */
+ /* Flash access mode is 128bit always so configure wait states to 6 */
- sam_eefc_initaccess(SAM_EFC_ACCESS_MODE_128, 4);
+ sam_eefc_initaccess(6);
Review Comment:
Suggestion: define a symbol with flash wait states equal 6 instead of hardcoding it in two places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org