You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/06/26 12:05:12 UTC

[GitHub] [myfaces] melloware commented on a diff in pull request #280: Reuse expression and avoid duplicate code.Easier to maintain.

melloware commented on code in PR #280:
URL: https://github.com/apache/myfaces/pull/280#discussion_r906804189


##########
impl/src/main/java/org/apache/myfaces/view/facelets/compiler/SAXCompiler.java:
##########
@@ -631,14 +631,15 @@ public void endDTD() throws SAXException
         @Override
         public void endElement(String uri, String localName, String qName) throws SAXException
         {
+            final boolean nameSpace = CompositeLibrary.NAMESPACE.equals(uri)

Review Comment:
   Maybe call the variable `hasNameSpace` or `isInNameSpace` something more explicit that its a boolean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org