[GitHub] [superset] michael-s-molina commented on pull request #22830: fix: Handles disabled options on Select All

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina commented on PR #22830:
URL: https://github.com/apache/superset/pull/22830#issuecomment-1412203730

   > Selecting all correctly ignores the disabled option, but un-selecting all does include the disabled option. Example: We have options "A", "B" and "C". Option "A" is selected by default and disabled so that user can't unselect it. Clicking "Select all" correctly adds options "B" and "C" to selection, but clicking it again unselects all options, including disabled "A".
   
   @kgabryje Can you provide an example? I tested in the Storybook but was not able to reproduce the bug.
   
   https://user-images.githubusercontent.com/70410625/216078994-52d2fc12-5eb6-4605-82aa-8bef4fed371e.mov


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org