You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Takeshi Yamamuro (Jira)" <ji...@apache.org> on 2021/03/26 14:41:00 UTC

[jira] [Resolved] (SPARK-34846) Sort output rows in SQLQueryTestSuite even if a plan has a Sort node

     [ https://issues.apache.org/jira/browse/SPARK-34846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Takeshi Yamamuro resolved SPARK-34846.
--------------------------------------
    Resolution: Won't Fix

> Sort output rows in SQLQueryTestSuite even if a plan has a Sort node
> --------------------------------------------------------------------
>
>                 Key: SPARK-34846
>                 URL: https://issues.apache.org/jira/browse/SPARK-34846
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL, Tests
>    Affects Versions: 3.2.0, 3.1.2, 3.0.3
>            Reporter: Takeshi Yamamuro
>            Priority: Minor
>
> This ticket aims at sorting output rows in SQLQueryTestSuite even if a given plan has a `Sort` node. In that case, the current logic skips sorting output rows (see the code below for details):
> https://github.com/apache/spark/blob/0494dc90af48ce7da0625485a4dc6917a244d580/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L503-L522
> But, I think we still need to sort output rows if the node just sort output rows by partial columns (instead of all columns). The current logic can lead to a flaky test behaviour.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org