You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/02/11 22:33:14 UTC
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12449
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
[tools] Add tablet data dirs to 'kudu remote replica list'
This is useful to find out the data dirs for a tablet on a remote server
while the server is running. For example, it could be used to
investigate performance issues related to the devices on which the data
for the tablet is stored.
Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
---
M src/kudu/tablet/tablet.proto
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_remote_replica.cc
4 files changed, 56 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/12449/1
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12449
to look at the new patch set (#2).
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
[tools] Add tablet data dirs to 'kudu remote replica list'
This is useful to find out the data dirs for a tablet on a remote server
while the server is running. For example, it could be used to
investigate performance issues related to the devices on which the data
for the tablet is stored.
Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
---
M src/kudu/tablet/tablet.proto
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_remote_replica.cc
4 files changed, 68 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/12449/2
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 22:17:00 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet.proto
File src/kudu/tablet/tablet.proto:
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet.proto@104
PS1, Line 104: bytes
Curious, why bytes and not string?
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet_replica.cc
File src/kudu/tablet/tablet_replica.cc:
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet_replica.cc@448
PS1, Line 448: --
nit: prepend a space
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tools/kudu-tool-test.cc@1910
PS1, Line 1910:
: // Some fields like state or estimated on disk size may vary. Just check a
: // few whose values we should know exactly.
: ASSERT_STR_CONTAINS(stdout,
: Substitute("Tablet id: $0", tablet_status.tablet_id()));
: ASSERT_STR_CONTAINS(stdout,
: Substitute("Table name: $0", workload.table_name()));
: ASSERT_STR_CONTAINS(stdout,
: Substitute("Data dirs: $0", JoinStrings(tablet_status.data_dirs(), ", ")));
Could you also tombstone the replica and run this?
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 12 Feb 2019 18:53:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
Patch Set 2: Verified+1
IWYU problem not related to this patch.
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 18:10:32 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet.proto
File src/kudu/tablet/tablet.proto:
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet.proto@104
PS1, Line 104: bytes
> Curious, why bytes and not string?
Directory and file names can be damn near anything in *nix, IIRC. Protobuf strings must be UTF-8.
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet_replica.cc
File src/kudu/tablet/tablet_replica.cc:
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet_replica.cc@448
PS1, Line 448: --
> nit: prepend a space
?
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tools/kudu-tool-test.cc@1892
PS1, Line 1892: ExternalMiniClusterOptions opts;
> You can set num_data_dirs to something more interesting to test the multi-d
Done
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tools/kudu-tool-test.cc@1910
PS1, Line 1910:
: // Some fields like state or estimated on disk size may vary. Just check a
: // few whose values we should know exactly.
: ASSERT_STR_CONTAINS(stdout,
: Substitute("Tablet id: $0", tablet_status.tablet_id()));
: ASSERT_STR_CONTAINS(stdout,
: Substitute("Table name: $0", workload.table_name()));
: ASSERT_STR_CONTAINS(stdout,
: Substitute("Data dirs: $0", JoinStrings(tablet_status.data_dirs(), ", ")));
> Could you also tombstone the replica and run this?
Done
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 20:34:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tools/kudu-tool-test.cc@1892
PS1, Line 1892: ExternalMiniClusterOptions opts;
You can set num_data_dirs to something more interesting to test the multi-data-dir case.
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 12 Feb 2019 19:25:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed a vote on this change.
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tablet/tablet_replica.cc
File src/kudu/tablet/tablet_replica.cc:
http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tablet/tablet_replica.cc@448
PS2, Line 448: // an empty 'data_dirs' in this case-- the state and last status will inform
nit: add a separating space
http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc@1898
PS2, Line 1898: workload.set_num_tablets(kNumTablets);
nit: add const ?
http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc@1901
PS2, Line 1901:
: TServerDetails* ts = ts_map_[cluster_->tablet_server(0)->uuid()];
: vector<ListTabletsResponsePB::StatusAndSchemaPB> tablets;
: ASSERT_OK(WaitForNumTabletsOnTS(ts, kNumTablets, kTim
nit: if you do std:move(opts), maybe move all the related code under a scope? That's to avoid re-using invalidated opts below in case of modifications, etc.
http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc@1923
PS2, Line 1923: TEST_F(ToolTest, TestLocalReplicaDelete) {
: NO_FATALS(StartMiniCluster());
:
: // TestWorkLoad.Setup() internally generates a table.
: TestWorkload workload(mini_cluster_.get());
: workload.set_num_replicas(1);
nit: if that info is exactly the same in both alive and tombstoned tablet, maybe create a functor and use it instead of duplicating the code?
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 03:56:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet.proto
File src/kudu/tablet/tablet.proto:
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet.proto@104
PS1, Line 104: bytes
> Directory and file names can be damn near anything in *nix, IIRC. Protobuf
Ah, good to know.
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet_replica.cc
File src/kudu/tablet/tablet_replica.cc:
http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet_replica.cc@448
PS1, Line 448: --
> ?
Minor grammar point, I've usually seen "--" used as: "in this case -- the state"
http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc@1940
PS2, Line 1940: JoinStrings(tablet_status.data_dirs(), ", "
Hrm, surprised this is the case. I would have thought the tombstone would have no data and hence no data dir group.
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 22:46:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
[tools] Add tablet data dirs to 'kudu remote replica list'
This is useful to find out the data dirs for a tablet on a remote server
while the server is running. For example, it could be used to
investigate performance issues related to the devices on which the data
for the tablet is stored.
Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Reviewed-on: http://gerrit.cloudera.org:8080/12449
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/tablet/tablet.proto
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_remote_replica.cc
4 files changed, 68 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Will Berkeley: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
Patch Set 3:
Actually the test was legit broken... :coneofshame:
I will fix with the third in this series.
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 18:40:08 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/12449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633
Gerrit-Change-Number: 12449
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 12 Feb 2019 19:30:55 +0000
Gerrit-HasComments: No