You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Subhrat Chaudhary via Review Board <no...@reviews.apache.org> on 2023/10/11 14:42:58 UTC

Review Request 74661: RANGER-4459: add filters for sharedResourceName and sharedResourceNamePartial in get sharedResource API #2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74661/
-----------------------------------------------------------

Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, and Prashant Satam.


Bugs: RANGER-4459
    https://issues.apache.org/jira/browse/RANGER-4459


Repository: ranger


Description
-------

We need to add support for filtering on sharedResourceName and sharedResourceNamePartial in the get sharedResource API. This will be used in the dataShare creation, where user can search through the resources.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java ed855446f 
  security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 90e9a6c02 
  security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java 0a11d4f1d 


Diff: https://reviews.apache.org/r/74661/diff/1/


Testing
-------

Validated filtering is working on the GET API - /gds/resource as expected based on the query params - sharedResourceName and sharedResourceNamePartial.


Thanks,

Subhrat Chaudhary


Re: Review Request 74661: RANGER-4459: add filters for sharedResourceName and sharedResourceNamePartial in get sharedResource API #2

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74661/#review225852
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 11, 2023, 2:42 p.m., Subhrat Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74661/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2023, 2:42 p.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, and Prashant Satam.
> 
> 
> Bugs: RANGER-4459
>     https://issues.apache.org/jira/browse/RANGER-4459
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> We need to add support for filtering on sharedResourceName and sharedResourceNamePartial in the get sharedResource API. This will be used in the dataShare creation, where user can search through the resources.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java ed855446f 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 90e9a6c02 
>   security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java 0a11d4f1d 
> 
> 
> Diff: https://reviews.apache.org/r/74661/diff/1/
> 
> 
> Testing
> -------
> 
> Validated filtering is working on the GET API - /gds/resource as expected based on the query params - sharedResourceName and sharedResourceNamePartial.
> 
> 
> Thanks,
> 
> Subhrat Chaudhary
> 
>