You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/06/18 13:17:11 UTC
[commons-numbers] 26/34: Replace assertNotEquals with assertFalse
where necessary
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit c76f3e73400d53b41f248c28219afd59717c9cbe
Author: Schamschi <he...@gmx.at>
AuthorDate: Tue Jun 11 17:11:50 2019 +0200
Replace assertNotEquals with assertFalse where necessary
Don't make assumptions about which parameter's equals(Object) method is called in assertNotEquals(Object, Object)
---
.../src/test/java/org/apache/commons/numbers/complex/ComplexTest.java | 2 +-
.../java/org/apache/commons/numbers/fraction/BigFractionTest.java | 4 ++--
.../java/org/apache/commons/numbers/quaternion/QuaternionTest.java | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
index 9dff601..a105dcc 100644
--- a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
+++ b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
@@ -404,7 +404,7 @@ public class ComplexTest {
@Test
public void testEqualsClass() {
Complex x = Complex.ofCartesian(3.0, 4.0);
- Assertions.assertNotEquals(x, this);
+ Assertions.assertFalse(x.equals(this));
}
@Test
diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
index 539c624..a2e4020 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
@@ -597,8 +597,8 @@ public class BigFractionTest {
BigFraction zero = BigFraction.of(0, 1);
BigFraction nullFraction = null;
Assertions.assertEquals(zero, zero);
- Assertions.assertNotEquals(nullFraction, zero);
- Assertions.assertNotEquals(0.0d, zero);
+ Assertions.assertFalse(zero.equals(nullFraction));
+ Assertions.assertFalse(zero.equals(Double.valueOf(0)));
BigFraction zero2 = BigFraction.of(0, 2);
Assertions.assertEquals(zero, zero2);
Assertions.assertEquals(zero.hashCode(), zero2.hashCode());
diff --git a/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java b/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java
index b2f7a82..7a787dc 100644
--- a/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java
+++ b/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java
@@ -378,7 +378,7 @@ public class QuaternionTest {
final Quaternion q3 = Quaternion.of(one, Math.nextUp(one), one, one);
Assertions.assertNotEquals(q3, q1);
- Assertions.assertNotEquals("bar", q3);
+ Assertions.assertFalse(q3.equals("bar"));
}
@Test