You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "cbmarcum (via GitHub)" <gi...@apache.org> on 2025/08/07 22:52:44 UTC

[PR] chore: add versioning section to RELEASE.md and a link in README.md [grails-core]

cbmarcum opened a new pull request, #14962:
URL: https://github.com/apache/grails-core/pull/14962

   Refs: #14959


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: add versioning section to RELEASE.md and a link in README.md [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #14962:
URL: https://github.com/apache/grails-core/pull/14962#discussion_r2265356108


##########
README.md:
##########
@@ -117,6 +117,10 @@ For further information, please consult the [documentation](https://docs.grails.
 Apache Grails is licensed under the Apache License, Version 2.0. For details, see
 the [LICENSE](./LICENSE).
 
+## Versioning
+
+The Apache Grails versioning scheme is defined in [RELEASE.md Appendix: Versioning](https://github.com/apache/grails-core/blob/7.0.x/RELEASE.md#appendix-versioning).

Review Comment:
   I think you can get away with just the following here, which saves us from adjusting the branch going forward.
   
   `[RELEASE.md Appendix: Versioning](RELEASE.md#appendix-versioning)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: add versioning section to RELEASE.md and a link in README.md [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #14962:
URL: https://github.com/apache/grails-core/pull/14962#issuecomment-3172758805

   I think adding a sentence stating that we follow the Spring release versioning scheme, with or without link, and that we release soon after each Spring Boot release, would add clarity.  And a sentence distinguishing between a RCX release and a release candidate from the ASF release process perfective.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: add versioning section to RELEASE.md and a link in README.md [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #14962:
URL: https://github.com/apache/grails-core/pull/14962#issuecomment-3172631564

   Great Job @cbmarcum.  While this explains our versioning scheme, it does not address ASF 'release' confusion.  
   
   @jamesfredley @matrei Should we add something that clarifies why we put out releases this way?  I think @jamesfredley linked to Spring's guide as one example; should we mention that we base our versioning off Spring too?  I'm also ok with only adding this and addressing these concerns outside of the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: add versioning section to RELEASE.md and a link in README.md [grails-core]

Posted by "cbmarcum (via GitHub)" <gi...@apache.org>.
cbmarcum commented on PR #14962:
URL: https://github.com/apache/grails-core/pull/14962#issuecomment-3181231532

   @jamesfredley, @jdaugherty, and All, let me know what you think of the modifications.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: add versioning section to RELEASE.md and a link in README.md [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #14962:
URL: https://github.com/apache/grails-core/pull/14962


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: add versioning section to RELEASE.md and a link in README.md [grails-core]

Posted by "cbmarcum (via GitHub)" <gi...@apache.org>.
cbmarcum commented on code in PR #14962:
URL: https://github.com/apache/grails-core/pull/14962#discussion_r2268201446


##########
README.md:
##########
@@ -117,6 +117,10 @@ For further information, please consult the [documentation](https://docs.grails.
 Apache Grails is licensed under the Apache License, Version 2.0. For details, see
 the [LICENSE](./LICENSE).
 
+## Versioning
+
+The Apache Grails versioning scheme is defined in [RELEASE.md Appendix: Versioning](https://github.com/apache/grails-core/blob/7.0.x/RELEASE.md#appendix-versioning).

Review Comment:
   Thanks, I'll make the adjustments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org