You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/19 23:31:57 UTC

[GitHub] [flink] bowenli86 edited a comment on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors

bowenli86 edited a comment on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors
URL: https://github.com/apache/flink/pull/9172#issuecomment-513410194
 
 
   > Keeping the name unchanged is fine to me. However, I don't expect that we will use this builder to build Hive CatalogTable. That builder probably will reside in Hive connector package rather than here. Therefore, I don't think we even need to have a member variable "isGeneric" in CatalogTableBuilder. Putting it here might give a misconception.
   
   The builder can be used with any catalog for any source/sink that have a descriptor, like csv, kafka, elasticsearch, etc. Why would it reside in Hive connector? Do you actually mean "isGeneric"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services