You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sekruse <gi...@git.apache.org> on 2014/09/10 19:01:06 UTC
[GitHub] incubator-flink pull request: [FLINK-1096] Correction to histogram...
GitHub user sekruse opened a pull request:
https://github.com/apache/incubator-flink/pull/117
[FLINK-1096] Correction to histogram accumulator
* each key is associated with the number of times it was inserted into the accumulator
* backed histogram with a tree map to present the entries sorted by key
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sekruse/incubator-flink FLINK-1096
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit 5080784896b8265bb58bf5c3fb471552c1277b37
Author: Sebastian Kruse <se...@hpi.de>
Date: 2014-09-10T16:59:09Z
[FLINK-1096] Correction to histogram accumulator
* each key is associated with the number of times it was inserted into the accumulator
* backed histogram with a tree map to present the entries sorted by key
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1096] Correction to histogram...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/117#issuecomment-55280405
Integration tests are only triggered with ``mvn verify``.
Not sure if there are any that depend on the changed code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1096] Correction to histogram...
Posted by sekruse <gi...@git.apache.org>.
Github user sekruse commented on the pull request:
https://github.com/apache/incubator-flink/pull/117#issuecomment-55279816
Oh, indeed, I seem to have missed a test. I changed that one and now ran a {{mvn test}} successfully on my machine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1096] Correction to histogram...
Posted by sekruse <gi...@git.apache.org>.
Github user sekruse commented on the pull request:
https://github.com/apache/incubator-flink/pull/117#issuecomment-55910613
I don't think that this issue is caused by the histogram, it is just a problem with one of the integration tests. I can report that issue, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1096] Correction to histogram...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/117#issuecomment-55911250
I think adding a JIRA ticket for the issue would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1096] Correction to histogram...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/117#issuecomment-55941511
I think, there is already a ticket for this issue (FLINK-98).
Please check and add a comment if you think something is missing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1096] Correction to histogram...
Posted by sekruse <gi...@git.apache.org>.
Github user sekruse commented on the pull request:
https://github.com/apache/incubator-flink/pull/117#issuecomment-55284546
Ah okay, the more you know :smiley:
Unfortunately, on my Windows, there seems to be an issue with the deletion of a temp file, so that I cannot actually run the whole integration tests there. On travis, it seems to be passing now, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1096] Correction to histogram...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/117#issuecomment-55266868
Thanks for the PR.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1096] Correction to histogram...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/117#issuecomment-56306783
This looks good to me, I will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1096] Correction to histogram...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/117#issuecomment-55910128
Do you think its difficult to fix the temp file deletion? Would be cool to have support for Windows as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1096] Correction to histogram...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---