You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by cr...@apache.org on 2002/04/29 18:32:45 UTC

cvs commit: jakarta-commons/beanutils/src/java/org/apache/commons/beanutils/converters BooleanConverter.java

craigmcc    02/04/29 09:32:44

  Modified:    beanutils/src/java/org/apache/commons/beanutils/converters
                        BooleanConverter.java
  Log:
  When doing String->Boolean conversions, recognize "1" and "0" as synonyms for
  "true" and "false", as is done in XML/Schema and many other programming
  environments.
  
  PR: Bugzilla #8627
  Submitted by:	Joe Germuska <joe at germuska.com>
  
  Revision  Changes    Path
  1.3       +8 -6      jakarta-commons/beanutils/src/java/org/apache/commons/beanutils/converters/BooleanConverter.java
  
  Index: BooleanConverter.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/beanutils/src/java/org/apache/commons/beanutils/converters/BooleanConverter.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- BooleanConverter.java	11 Apr 2002 19:50:06 -0000	1.2
  +++ BooleanConverter.java	29 Apr 2002 16:32:44 -0000	1.3
  @@ -1,7 +1,7 @@
   /*
  - * $Header: /home/cvs/jakarta-commons/beanutils/src/java/org/apache/commons/beanutils/converters/BooleanConverter.java,v 1.2 2002/04/11 19:50:06 craigmcc Exp $
  - * $Revision: 1.2 $
  - * $Date: 2002/04/11 19:50:06 $
  + * $Header: /home/cvs/jakarta-commons/beanutils/src/java/org/apache/commons/beanutils/converters/BooleanConverter.java,v 1.3 2002/04/29 16:32:44 craigmcc Exp $
  + * $Revision: 1.3 $
  + * $Date: 2002/04/29 16:32:44 $
    *
    * ====================================================================
    *
  @@ -74,7 +74,7 @@
    * error occurs.</p>
    *
    * @author Craig R. McClanahan
  - * @version $Revision: 1.2 $ $Date: 2002/04/11 19:50:06 $
  + * @version $Revision: 1.3 $ $Date: 2002/04/29 16:32:44 $
    * @since 1.3
    */
   
  @@ -152,11 +152,13 @@
               String stringValue = (String) value;
               if (stringValue.equalsIgnoreCase("yes") ||
                   stringValue.equalsIgnoreCase("true") ||
  -                stringValue.equalsIgnoreCase("on")) {
  +                stringValue.equalsIgnoreCase("on") ||
  +                stringValue.equalsIgnoreCase("1")) {
                   return (Boolean.TRUE);
               } else if (stringValue.equalsIgnoreCase("no") ||
                          stringValue.equalsIgnoreCase("false") ||
  -                       stringValue.equalsIgnoreCase("off")) {
  +                       stringValue.equalsIgnoreCase("off") ||
  +                       stringValue.equalsIgnoreCase("0")) {
                   return (Boolean.FALSE);
               } else if (useDefault) {
                   return (defaultValue);
  
  
  

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>