You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/15 02:00:21 UTC
[GitHub] [arrow] michalursa opened a new pull request, #13616: ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node
michalursa opened a new pull request, #13616:
URL: https://github.com/apache/arrow/pull/13616
Fixing off-by-one error in hash join node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13616: ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13616:
URL: https://github.com/apache/arrow/pull/13616#issuecomment-1185095187
Revision: 53ad1c2e52636785dcd8579e5a33592e50b385c2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1d8d74c193](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1d8d74c193)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1d8d74c193-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-debian-11-cpp-i386)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-fedora-35-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1d8d74c193-github-test-ubuntu-22.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace merged pull request #13616: ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node
Posted by GitBox <gi...@apache.org>.
westonpace merged PR #13616:
URL: https://github.com/apache/arrow/pull/13616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13616: ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13616:
URL: https://github.com/apache/arrow/pull/13616#issuecomment-1185131244
Revision: 147aadbf524752d3126110a24a1af71450d4679f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-206b6227c4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-206b6227c4)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-206b6227c4-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-debian-11-cpp-i386)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-fedora-35-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-206b6227c4-github-test-ubuntu-22.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13616: ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13616:
URL: https://github.com/apache/arrow/pull/13616#issuecomment-1185091549
https://issues.apache.org/jira/browse/ARROW-17071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] michalursa commented on pull request #13616: ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node
Posted by GitBox <gi...@apache.org>.
michalursa commented on PR #13616:
URL: https://github.com/apache/arrow/pull/13616#issuecomment-1185091516
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #13616: ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node
Posted by GitBox <gi...@apache.org>.
westonpace commented on PR #13616:
URL: https://github.com/apache/arrow/pull/13616#issuecomment-1188058269
> could the [test-ubuntu-20.04-cpp-thread-sanitizer](https://github.com/ursacomputing/crossbow/runs/7351519875?check_suite_focus=true) be related to the change?
I don't think so. The asof join node has been failing TSAN since before the hash-join code merged. See https://issues.apache.org/jira/browse/ARROW-16964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13616: ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13616:
URL: https://github.com/apache/arrow/pull/13616#issuecomment-1185091560
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13616: ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13616:
URL: https://github.com/apache/arrow/pull/13616#issuecomment-1187024347
could the [test-ubuntu-20.04-cpp-thread-sanitizer](https://github.com/ursacomputing/crossbow/runs/7351519875?check_suite_focus=true) be related to the change? Asking because it is on the `asof-join` instead of the `hash-join` : `arrow-compute-asof-join-node-test`
```
SUMMARY: ThreadSanitizer: data race /arrow/cpp/src/arrow/compute/exec/asof_join_node.cc:256:7 in arrow::compute::InputState::Push(std::shared_ptr<arrow::RecordBatch> const&)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] michalursa commented on pull request #13616: ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node
Posted by GitBox <gi...@apache.org>.
michalursa commented on PR #13616:
URL: https://github.com/apache/arrow/pull/13616#issuecomment-1185114544
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13616: ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13616:
URL: https://github.com/apache/arrow/pull/13616#issuecomment-1188307460
Benchmark runs are scheduled for baseline = ffd31d8c9d525a58d83b7908417d625c61a086a6 and contender = abcfbd785e988db67e7546b5c0263acdce2575d4. abcfbd785e988db67e7546b5c0263acdce2575d4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:2.27% :arrow_up:2.27%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f412fc6289fa41cab8e9de228049dab9...3e658fe555694bb5902fd8f046416740/)
[Failed :arrow_down:0.7% :arrow_up:0.21%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/eec3a08dfdc643f7b0bd7c87009541a1...e3f74e2083744b46acca7ccc1b370ff4/)
[Failed :arrow_down:0.33% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b9d8ed00e15547c791f630e7e533d681...34f3dc76ea864713a6c0d9df15c02450/)
[Finished :arrow_down:0.61% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7348080cb0274b419a14b18cbde5ed47...567c7f670df24bf9b0a196faef6baadf/)
Buildkite builds:
[Failed] [`abcfbd78` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1130)
[Failed] [`abcfbd78` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1135)
[Failed] [`abcfbd78` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1122)
[Finished] [`abcfbd78` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1139)
[Failed] [`ffd31d8c` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1129)
[Failed] [`ffd31d8c` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1134)
[Failed] [`ffd31d8c` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1121)
[Finished] [`ffd31d8c` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1138)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org