You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/03 02:30:37 UTC
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #10853: fix issue: add new modules and SPIs to shade plugin.
AlbumenJ commented on code in PR #10853:
URL: https://github.com/apache/dubbo/pull/10853#discussion_r1012447176
##########
dubbo-distribution/dubbo-all/pom.xml:
##########
@@ -1119,6 +1129,42 @@
META-INF/dubbo/internal/org.apache.dubbo.validation.Validation
</resource>
</transformer>
+ <transformer
+ implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
+ <resource>
+ META-INF/services/org.apache.dubbo.common.extension.LoadingStrategy
+ </resource>
+ </transformer>
+ <transformer
+ implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
+ <resource>
+ META-INF/dubbo/internal/org.apache.dubbo.metadata.rest.ServiceRestMetadataResolver
+ </resource>
+ </transformer>
+ <transformer
+ implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
+ <resource>
+ META-INF/dubbo/internal/org.apache.dubbo.registry.client.metadata.ServiceInstanceNotificationCustomizer
Review Comment:
Try define a plugin to check if transformers are comprehensive.
##########
dubbo-distribution/dubbo-all/pom.xml:
##########
@@ -468,6 +468,16 @@
<include>org.apache.dubbo:dubbo-compiler</include>
<include>org.apache.dubbo:dubbo-kubernetes</include>
<include>org.apache.dubbo:dubbo-xds</include>
+ <include>org.apache.dubbo:dubbo-filter</include>
+ <include>org.apache.dubbo:dubbo-filter-cache</include>
+ <include>org.apache.dubbo:dubbo-filter-validation</include>
+ <include>org.apache.dubbo:dubbo-spring-boot</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-compatible</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-autoconfigure-compatible</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-autoconfigure</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-starter</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-actuator-compatible</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-actuator</include>
Review Comment:
`dubbo-spring-boot` should not be shaded into `dubbo-all`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org