[GitHub] [dolphinscheduler] lenboo commented on a diff in pull request #10307: [Feature][Permission] Reconstruction of permissions of resource center and monitoring center.

[GitBox <gi...@apache.org>]

lenboo commented on code in PR #10307:
URL: https://github.com/apache/dolphinscheduler/pull/10307#discussion_r885117964


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.xml:
##########
@@ -62,11 +62,17 @@
         <if test="searchVal!= null and searchVal != ''">
             and udf.func_name like concat('%', #{searchVal}, '%')
         </if>
-        <if test="userId != 0">
-            and udf.id in (
-            select udf_id from t_ds_relation_udfs_user where user_id=#{userId}
-            union select id as udf_id from t_ds_udfs where user_id=#{userId})
+        <if test="ids != null and ids.size() > 0">
+            and udf.id in
+            <foreach collection="ids" item="i" open="(" close=")" separator=",">
+                #{i}
+            </foreach>
         </if>
+<!--        <if test="userId != 0">-->

Review Comment:
   We can delete the unused code. Maybe you can fix it later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org