You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "ruanwenjun (via GitHub)" <gi...@apache.org> on 2026/05/13 12:09:08 UTC
[PR] [Improvement-18249][DAO] Route DataSourceMapper and DataSourceUserMapper access through repository Dao [dolphinscheduler]
ruanwenjun opened a new pull request, #18259:
URL: https://github.com/apache/dolphinscheduler/pull/18259
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Was this PR generated or assisted by AI?
YES, gpt 5.5
## Purpose of the pull request
Introduce DataSourceDao and DataSourceUserDao so the api layer depends only on the repository abstraction. The two mappers are bundled because DataSourceServiceImpl and UsersServiceImpl share both.
DataSourceDao renames mapper.selectPaging / selectPagingByIds to queryDataSourcePaging / queryDataSourcePagingByIds and folds the selectByMap("user_id", X) idiom from DataSourceServiceImpl into queryByUserId(int) so the QueryWrapper-style call no longer leaks into the api layer.
DataSourceUserDao exposes deleteByUserId / deleteByDatasourceId as void (the mapper-returned row count was never consulted at the call sites).
Tracking issue: #18249
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18249][DAO] Route DataSourceMapper and DataSourceUserMapper access through repository Dao [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18259:
URL: https://github.com/apache/dolphinscheduler/pull/18259#issuecomment-4441052844
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=18259&metric=new_coverage&view=list) (required ≥ 60%)
<!-- sqra:qg_revision=184a56e79b09572a8f677db63e8a15842bedec63279916924e37cd83e67fccc8 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18249][DAO] Route DataSourceMapper and DataSourceUserMapper access through repository Dao [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18259:
URL: https://github.com/apache/dolphinscheduler/pull/18259#issuecomment-4477934118
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=18259&metric=new_coverage&view=list) (required ≥ 60%)
<!-- sqra:qg_revision=184a56e79b09572a8f677db63e8a15842bedec63279916924e37cd83e67fccc8 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18249][DAO] Route DataSourceMapper and DataSourceUserMapper access through repository Dao [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18259:
URL: https://github.com/apache/dolphinscheduler/pull/18259#issuecomment-4468911205
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=18259&metric=new_coverage&view=list) (required ≥ 60%)
<!-- sqra:qg_revision=184a56e79b09572a8f677db63e8a15842bedec63279916924e37cd83e67fccc8 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18249][DAO] Route DataSourceMapper and DataSourceUserMapper access through repository Dao [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #18259:
URL: https://github.com/apache/dolphinscheduler/pull/18259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18249][DAO] Route DataSourceMapper and DataSourceUserMapper access through repository Dao [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18259:
URL: https://github.com/apache/dolphinscheduler/pull/18259#issuecomment-4457603204
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=18259&metric=new_coverage&view=list) (required ≥ 60%)
<!-- sqra:qg_revision=184a56e79b09572a8f677db63e8a15842bedec63279916924e37cd83e67fccc8 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18249][DAO] Route DataSourceMapper and DataSourceUserMapper access through repository Dao [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18259:
URL: https://github.com/apache/dolphinscheduler/pull/18259#issuecomment-4456275770
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=18259&metric=new_coverage&view=list) (required ≥ 60%)
<!-- sqra:qg_revision=184a56e79b09572a8f677db63e8a15842bedec63279916924e37cd83e67fccc8 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18249][DAO] Route DataSourceMapper and DataSourceUserMapper access through repository Dao [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18259:
URL: https://github.com/apache/dolphinscheduler/pull/18259#issuecomment-4459283657
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=18259&metric=new_coverage&view=list) (required ≥ 60%)
<!-- sqra:qg_revision=184a56e79b09572a8f677db63e8a15842bedec63279916924e37cd83e67fccc8 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18259)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org