You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by brad <gi...@git.apache.org> on 2015/07/22 01:01:25 UTC
[GitHub] cordova-plugin-inappbrowser pull request: give the ability to trus...
GitHub user brad opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/111
give the ability to trust a certificate authority
We found ourselves in a position where we needed to access a site with a certificate issued by a CA not trusted by default in Android. In this case the browser fails silently and remains blank. This is the workaround we came up with:
* You save the CA certificate to `www/trusted-ca.der` when building your cordova app.
* When the plugin loads an https site, the CA gets added to the trusted CAs for `HttpsUrlConnection`
* When an `SSLError` is received, we do the following:
* Check if the domain of the URL the error is about is in the whitelist (which starts out empty). If so, we ignore the error and proceed.
* If not, we check if `HttpsUrlConnection` can connect to the domain without a problem. If so, we add it to the whitelist, ignore the error and proceed. If not, we fail.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/orcasgit/cordova-plugin-inappbrowser trust_ca
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
commit 0f8001175968380830cc47d7a3ab9ed116d09eb5
Author: Brad Pitcher <br...@gmail.com>
Date: 2015-07-10T22:25:20Z
give the ability to trust a certificate authority
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #111: give the ability to trust a certific...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/111
This has the following wrong with it:
1. You changed the package.json
2. You don't have a JIRA issue attached to this
3. There are other conflicts with the current InAppBrowser code.
If you are still interested in contributing, please fix these issues, and we can then take a look at this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #111: give the ability to trust a certific...
Posted by brad <gi...@git.apache.org>.
Github user brad commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/111
@infil00p Sorry about that. I will make a new PR without those issues
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #111: give the ability to trust a c...
Posted by brad <gi...@git.apache.org>.
Github user brad closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/111
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #111: give the ability to trust a certific...
Posted by brad <gi...@git.apache.org>.
Github user brad commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/111
Superseded by https://github.com/apache/cordova-plugin-inappbrowser/pull/243
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org