[GitHub] [cassandra] smiklosovic commented on a change in pull request #1043: Obfuscate password for DCL statements in QueryEvents

[GitBox <gi...@apache.org>]

smiklosovic commented on a change in pull request #1043:
URL: https://github.com/apache/cassandra/pull/1043#discussion_r646323878



##########
File path: src/java/org/apache/cassandra/cql3/QueryEvents.java
##########
@@ -72,8 +82,9 @@ public void notifyQuerySuccess(CQLStatement statement,
     {
         try
         {
+
             for (Listener listener : listeners)
-                listener.querySuccess(statement, query, options, state, queryTime, response);
+                listener.querySuccess(statement, possiblyObfuscateQuery(statement, query), options, state, queryTime, response);

Review comment:
       @sumanth-pasupuleti would it be possible to move this method invocation _outside_ of `for`, because if you have 10 listeners, you are basically obfuscating the same string 10 times but 1 time is just enough. This holds for all other places in this class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org