You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/19 13:27:26 UTC
[GitHub] [maven-resolver] cstamas opened a new pull request, #204: [MRESOLVER-280] Upgrade invoker, install, deploy, require Mvn 3.8.4+
cstamas opened a new pull request, #204:
URL: https://github.com/apache/maven-resolver/pull/204
Upgrade following plugins:
* m-invoker-p
* m-install-p
* m-deploy-p
Require Maven 3.8.4+ for building.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] gnodet commented on a diff in pull request #204: [MRESOLVER-280] Upgrade invoker, install, deploy, require Mvn 3.8.4+
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #204:
URL: https://github.com/apache/maven-resolver/pull/204#discussion_r1000249506
##########
pom.xml:
##########
@@ -79,6 +79,7 @@
<guavaVersion>30.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
<slf4jVersion>1.7.36</slf4jVersion>
+ <minimalMavenBuildVersion>3.8.4</minimalMavenBuildVersion>
Review Comment:
Is that just for reference / documentation ? if so, a comment would be welcomed so that it is not removed by accident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #204: [MRESOLVER-280] Upgrade invoker, install, deploy, require Mvn 3.8.4+
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #204:
URL: https://github.com/apache/maven-resolver/pull/204#discussion_r1000194425
##########
maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml:
##########
@@ -97,7 +97,7 @@
<plugins>
<plugin>
<artifactId>maven-invoker-plugin</artifactId>
- <version>3.2.2</version>
+ <version>3.3.0</version>
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #204: [MRESOLVER-280] Upgrade invoker, install, deploy, require Mvn 3.8.4+
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #204:
URL: https://github.com/apache/maven-resolver/pull/204#discussion_r1000253285
##########
pom.xml:
##########
@@ -79,6 +79,7 @@
<guavaVersion>30.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
<slf4jVersion>1.7.36</slf4jVersion>
+ <minimalMavenBuildVersion>3.8.4</minimalMavenBuildVersion>
Review Comment:
No, parent pom (apache) contains enforcer that enforces usable Maven based on this property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] gnodet commented on a diff in pull request #204: [MRESOLVER-280] Upgrade invoker, install, deploy, require Mvn 3.8.4+
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #204:
URL: https://github.com/apache/maven-resolver/pull/204#discussion_r1000249506
##########
pom.xml:
##########
@@ -79,6 +79,7 @@
<guavaVersion>30.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
<slf4jVersion>1.7.36</slf4jVersion>
+ <minimalMavenBuildVersion>3.8.4</minimalMavenBuildVersion>
Review Comment:
Is that just for reference ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] slawekjaranowski commented on a diff in pull request #204: [MRESOLVER-280] Upgrade invoker, install, deploy, require Mvn 3.8.4+
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #204:
URL: https://github.com/apache/maven-resolver/pull/204#discussion_r999837320
##########
maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml:
##########
@@ -97,7 +97,7 @@
<plugins>
<plugin>
<artifactId>maven-invoker-plugin</artifactId>
- <version>3.2.2</version>
+ <version>3.3.0</version>
Review Comment:
It is provided by parent in the same version
##########
pom.xml:
##########
@@ -285,6 +286,16 @@
<build>
<pluginManagement>
<plugins>
+ <plugin> <!-- remove once parent POM updated -->
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-deploy-plugin</artifactId>
+ <version>3.0.0</version>
Review Comment:
https://issues.apache.org/jira/browse/MPOM-332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas merged pull request #204: [MRESOLVER-280] Upgrade invoker, install, deploy, require Mvn 3.8.4+
Posted by GitBox <gi...@apache.org>.
cstamas merged PR #204:
URL: https://github.com/apache/maven-resolver/pull/204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org