You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2025/02/22 00:33:17 UTC
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22519
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
In part 1, when creating FileDescriptor.java, we accidentally switched
to the StringUtils in commons-lang (2.6) instead of that from
commons-lang3, which undid some work in IMPALA-13618. This patch
corrects this, so we only use classes from commons-lang3 from now on.
Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
---
M fe/src/main/java/org/apache/impala/catalog/FileDescriptor.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/22519/1
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22519 )
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18336/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Feb 2025 01:00:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22519 )
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+1
>
> Is it possible to remove commons-lang (2.6) so we don't accidentally make the same mistake again?
Sounds like no if Hadoop is still using it. Once they've fully updated this shouldn't happen again.
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Feb 2025 18:22:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22519 )
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
In part 1, when creating FileDescriptor.java, we accidentally switched
to the StringUtils in commons-lang (2.6) instead of that from
commons-lang3, which undid some work in IMPALA-13618. This patch
corrects this, so we only use classes from commons-lang3 from now on.
Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Reviewed-on: http://gerrit.cloudera.org:8080/22519
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Daniel Becker <da...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/FileDescriptor.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Daniel Becker: Looks good to me, but someone else must approve
Michael Smith: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22519 )
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Feb 2025 06:40:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22519 )
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
Patch Set 1:
> Patch Set 1:
>
> Did something get merged without a rebase? How would this still build?
Thanks Michael! It looks like commons-lang (2.6) is still transitively pulled in by hadoop-hdfs according to the output of "mvn dependency:tree".
[INFO] +- org.apache.hadoop:hadoop-hdfs:jar:3.1.1.7.2.18.0-641:compile
[INFO] | +- org.eclipse.jetty:jetty-util:jar:9.4.53.v20231009:compile
[INFO] | +- com.sun.jersey:jersey-core:jar:1.19.4:compile
[INFO] | | \- javax.ws.rs:jsr311-api:jar:1.1.1:compile
[INFO] | +- commons-io:commons-io:jar:2.11.0:compile
[INFO] | +- commons-lang:commons-lang:jar:2.6:compile
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Feb 2025 00:48:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22519 )
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
Patch Set 1:
Hi all, please let me know if there is any suggestion. Thanks very much for the help!
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Feb 2025 00:35:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22519 )
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Feb 2025 18:22:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22519 )
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
Patch Set 1: Code-Review+1
Is it possible to remove commons-lang (2.6) so we don't accidentally make the same mistake again?
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Feb 2025 17:09:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22519 )
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
Patch Set 1:
Thanks for the review Michael and Daniel! Carry forward Michael's +2 and merge the patch.
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Feb 2025 18:47:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22519 )
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11484/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Feb 2025 01:12:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22519 )
Change subject: IMPALA-13739: Part1 (Addendum): Import StringUtils from commons-lang3
......................................................................
Patch Set 1:
Did something get merged without a rebase? How would this still build?
--
To view, visit http://gerrit.cloudera.org:8080/22519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d4d0ab03c549f8d73149651e3e735bd4f8d20a
Gerrit-Change-Number: 22519
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Feb 2025 00:35:34 +0000
Gerrit-HasComments: No