You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2022/06/10 18:30:41 UTC
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18611
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
IMPALA-11342: Fix class loading in Hive UDFs' constructors
Loading new classes from the same jar in the constructor of UDFs
did not work in the catalog because the URLClassLoader was closed
too early. Extended the lifecycle of the class loader a bit to
let the catalog finish all initialisation.
Note that the instantiation of legacy Hive UDFs doesn't seem
necessary in the catalog, we can get all relevant info from
the class. Generic UDFs do need to be instantiated to be able
to call initialize().
Testing:
- added new classes to load in test UDFs and loaded these
in constructor / initialize()
- ran the Hive UDF ee tests
Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
---
M fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactoryImpl.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java
M java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java
M java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java
A java/test-hive-udfs/src/main/java/org/apache/impala/UtilForUdfConstructor.java
A java/test-hive-udfs/src/main/java/org/apache/impala/UtilForUdfInitialize.java
6 files changed, 88 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/18611/1
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Steve Carlin, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18611
to look at the new patch set (#2).
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
IMPALA-11342: Fix class loading in Hive UDFs' constructors
Loading new classes from the same jar in the constructor of UDFs
did not work in the catalog because the URLClassLoader was closed
too early. Extended the lifecycle of the class loader a bit to
let the catalog finish all initialisation.
Note that the instantiation of legacy Hive UDFs doesn't seem
necessary in the catalog, we can get all relevant info from
the class. Generic UDFs do need to be instantiated to be able
to call initialize().
Testing:
- added new classes to load in test UDFs and loaded these
in constructor / initialize()
- ran the Hive UDF ee tests
Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
---
M fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactoryImpl.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java
M fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java
M java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java
M java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java
A java/test-hive-udfs/src/main/java/org/apache/impala/UtilForUdfConstructor.java
A java/test-hive-udfs/src/main/java/org/apache/impala/UtilForUdfInitialize.java
7 files changed, 87 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/18611/2
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10985/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Jul 2022 14:27:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
IMPALA-11342: Fix class loading in Hive UDFs' constructors
Loading new classes from the same jar in the constructor of UDFs
did not work in the catalog because the URLClassLoader was closed
too early. Extended the lifecycle of the class loader a bit to
let the catalog finish all initialisation.
Note that the instantiation of legacy Hive UDFs doesn't seem
necessary in the catalog, we can get all relevant info from
the class. Generic UDFs do need to be instantiated to be able
to call initialize().
Testing:
- added new classes to load in test UDFs and loaded these
in constructor / initialize()
- ran the Hive UDF ee tests
Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Reviewed-on: http://gerrit.cloudera.org:8080/18611
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactoryImpl.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java
M fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java
M java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java
M java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java
A java/test-hive-udfs/src/main/java/org/apache/impala/UtilForUdfConstructor.java
A java/test-hive-udfs/src/main/java/org/apache/impala/UtilForUdfInitialize.java
7 files changed, 87 insertions(+), 21 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 15:09:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Looks good, thanks.
http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java
File fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java:
http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java@62
PS1, Line 62: boolean persistLoader
Is there any place after this change where 'persistLoader' is false? If not, we may consider removing it to simplify the class.
http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java@79
PS1, Line 79: public void close() {
Nit: Add @Override annotation because now it is part of the implementation of the AutoCloseable interface.
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Jul 2022 12:24:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 19:58:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8341/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 15:10:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10752/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Jun 2022 18:50:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java
File java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java:
http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java@32
PS1, Line 32: String member_;
nit: private?
http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java
File java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java:
http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java@30
PS1, Line 30: String member_;
nit: private
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 15:49:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Jul 2022 18:59:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java
File fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java:
http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java@62
PS1, Line 62: G.debug("Loading UDF
> Is there any place after this change where 'persistLoader' is false? If not
It was always true, I am not sure why did I keep it.
http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java@79
PS1, Line 79: if (!(classLoader_ instanceof URLClassLoader)) {
> Nit: Add @Override annotation because now it is part of the implementation
Done
http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java
File java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java:
http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java@32
PS1, Line 32: public GenericImportsNearbyClassesUdf() {
> nit: private?
removed this "member_" - I think that JVM will load UtilForUdfConstructor / UtilForUdfInitialize anyway. The JIT can optimize it, but this happens only later.
https://stackoverflow.com/questions/14207401/java-how-will-jvm-optimise-the-call-to-a-void-and-empty-function
http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java
File java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java:
http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java@30
PS1, Line 30: public ImportsNearbyClassesUdf() {
> nit: private
See answer in GenericImportsNearbyClassesUdf
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Jul 2022 14:11:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 15:10:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8332/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Jul 2022 14:12:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................
Patch Set 1: Code-Review+1
Just nits posted above, giving a +1
--
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 15:50:09 +0000
Gerrit-HasComments: No