You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by zwoop <gi...@git.apache.org> on 2016/04/04 14:14:13 UTC
[GitHub] trafficserver pull request: TS-4302 Adds more control over the eve...
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/548
TS-4302 Adds more control over the event API to use
This also addresses the build problems on current Illumos, by prioritizing the ports interface. But as such, it can now be useful to allow overriding this, with an explicit configure option (since Illumos now supports both epoll and ports).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4302
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/548.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #548
----
commit 07b08bf1d93730ccd2f6e5d0fe73a117a06bd815
Author: Leif Hedstrom <zw...@apache.org>
Date: 2016-03-31T14:23:26Z
TS-4302 Adds more control over the event API to use
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4302 Adds more control over the eve...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/548#issuecomment-205451669
Thanks, yeah, I'll update the configuration. Yeah, it might make sense to make this selection at runtime, but of course it must also check for the existence of available eventers. @jpeach Would you be a peach and file a Jira on making this run-time selectable? It seems low importance, because the primary platform we support (Linux) really only supports epoll().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4302 Adds more control over the eve...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/548#issuecomment-205506347
@jpeach Agreed. Can you file another Jira, and ask jsime to add a section to this document where we document all options to configure ? That makes more sense than adding this new one (which is almost never going to be used).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4302 Adds more control over the eve...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/548
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4302 Adds more control over the eve...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/548#issuecomment-205503484
Hmmm, I don't know that it makes sense to add that document, we don't document most of the options in configure.ac, and there is a "help" message for this new option (configure --help)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4302 Adds more control over the eve...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/548#issuecomment-205504075
OK. I was thinking that we would start (continue?) documenting build process/dependencies/options more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4302 Adds more control over the eve...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/548#issuecomment-205422265
This looks reasonable to me. Eventually it might make sense to make this selection at run time?
Now that we have it, please update ``admin-guide/installation/index.en.rst``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---