You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/25 06:19:53 UTC

[GitHub] [incubator-superset] mistercrunch opened a new pull request #11056: style: fix too light form labels in DatabaseModal + DRY css

mistercrunch opened a new pull request #11056:
URL: https://github.com/apache/incubator-superset/pull/11056


   eventually should be moved away from bootstrap and onto a DRY ControlLabel component in our design system.
   
   <img width="463" alt="Screen Shot 2020-09-24 at 11 18 16 PM" src="https://user-images.githubusercontent.com/487433/94233228-6a5ce100-febc-11ea-86d9-a3ed71897388.png">
   <img width="346" alt="Screen Shot 2020-09-24 at 11 17 46 PM" src="https://user-images.githubusercontent.com/487433/94233229-6af57780-febc-11ea-8d45-71f4e5978fa1.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch merged pull request #11056: style: fix too light form labels in DatabaseModal + DRY css

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #11056:
URL: https://github.com/apache/incubator-superset/pull/11056


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on pull request #11056: style: fix too light form labels in DatabaseModal + DRY css

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11056:
URL: https://github.com/apache/incubator-superset/pull/11056#issuecomment-704003594


   Let's make sure @riahk is getting her GitHub notifications!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on pull request #11056: style: fix too light form labels in DatabaseModal + DRY css

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11056:
URL: https://github.com/apache/incubator-superset/pull/11056#issuecomment-699239283


   @riahk please review when you have a chance :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org