You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by bu...@apache.org on 2006/02/06 10:42:34 UTC

DO NOT REPLY [Bug 38527] New: - change of filters is not reflected

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38527>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38527

           Summary: change of filters is not reflected
           Product: Ant
           Version: 1.5.1
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Core tasks
        AssignedTo: dev@ant.apache.org
        ReportedBy: literakl@centrum.cz


I have build.xml with <filter filtersfile="conf_deploy.properties"/>
Then I have a file proxool.xml with filters: 
<driver-url>jdbc:mysql://localhost/@DB_SCHEMA@?useUnicode=true</driver-url>

I call ant to deploy this configuration file. Later I realize that there was
some typo in the filter, so I update the file conf_deploy.properties. Then I
call ant again, but nothing happens, no file is copied. The reason is that
source file proxool.xml was not changed. But it references filters defined in
modified file, so it must be changed. The workaround is to remove the target
file and then call ant.

I understand, that it would slow ant a hell, if you would scan all files to
detect, if it contains some property defined in modified properties file. But
current behaviour is not consistent and it is very confusing. So I propose to
redeploy all files having filtering attribute set on:

<copy todir="${DEPLOY_ABCLINUXU}/WEB-INF" filtering="true">

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


DO NOT REPLY [Bug 38527] - change of filters is not reflected

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38527>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38527





------- Additional Comments From stevel@apache.org  2006-02-07 11:25 -------
Leos,
There is one other workaround to this problem, one that is easier to code.

1. copy things to an intermediate dir. Do not use the global filter if you can;
its a lot safer to use a nested filterset.

<copy todir="build/intermediate" overwrite="true">
 <filterset refid="myFilterSet"/>
 <fileset ... />
</copy>

2. then copy from there to a dest, any files that are different
 <copy todir="${DEPLOY_ABCLINUXU}/WEB-INF" >
  <fileset dir="build/intermediate">
   <different targetdir="${DEPLOY_ABCLINUXU}/WEB-INF" />
  </fileset>
 <copy>

your copy+filter will run every time, but the second copy will strip out
anything that hasnt changed.
  <fileset>

 </copy>


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


DO NOT REPLY [Bug 38527] - change of filters is not reflected

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38527>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38527


stevel@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX




------- Additional Comments From stevel@apache.org  2006-02-06 12:19 -------
I see your point, and it isnt going to be fixed. 
1. backwards compatibility, as always
2. there are other places where dependency logic fails, even things like <javac>
Sometimes a clean build is the best thing to do.

You can use <uptodate> or the ant-contrib extensions to declare that a
target/sequence of tasks depends on certain files being up to date, and so write
a target that explicitly depends upon your source files.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org