[GitHub] [beam] omarismail94 commented on a change in pull request #13308: [BEAM-10891] Standardized developer build environment using Docker

[GitBox <gi...@apache.org>]

omarismail94 commented on a change in pull request #13308:
URL: https://github.com/apache/beam/pull/13308#discussion_r536193320



##########
File path: dev-support/docker/Dockerfile
##########
@@ -0,0 +1,154 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Dockerfile for installing the necessary dependencies for building Hadoop.
+# See BUILDING.txt.
+
+FROM ubuntu:20.04
+
+ARG DEBIAN_FRONTEND=noninteractive
+
+WORKDIR /root
+
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+#####
+# Disable suggests/recommends
+#####
+RUN echo APT::Install-Recommends "0"\; > /etc/apt/apt.conf.d/10disableextras
+RUN echo APT::Install-Suggests "0"\; >>  /etc/apt/apt.conf.d/10disableextras
+
+ENV DEBIAN_FRONTEND noninteractive
+ENV DEBCONF_TERSE true
+
+
+# hadolint ignore=DL3008
+###
+# Update and install common packages
+###
+RUN apt -q update \
+   && apt install -y software-properties-common apt-utils apt-transport-https ca-certificates \
+   && add-apt-repository -y ppa:deadsnakes/ppa \
+   && apt-get -q install -y --no-install-recommends \
+        bash-completion \
+        build-essential \
+        bzip2 \
+        wget \
+        curl \
+        docker.io \
+        g++ \
+        gcc \
+        git \
+        gnupg-agent \
+        rsync \
+        sudo \
+        vim \
+        locales \
+        wget \
+        time \
+        openjdk-8-jdk \
+        python3-setuptools \
+        python3-pip \
+        python3.6 \
+        python3.7 \
+        python3.8 \
+        virtualenv \
+        tox \
+        # Needed for pyenv:
+        make \
+        libssl-dev \
+        zlib1g-dev \
+        libbz2-dev \
+        libreadline-dev \
+        libsqlite3-dev \
+        llvm \
+        libncurses5-dev \
+        libncursesw5-dev \
+        xz-utils \
+        tk-dev \
+        libffi-dev \
+        liblzma-dev \
+        python-openssl
+
+###
+# Set the locale ( see https://stackoverflow.com/a/28406007/114196 )
+###
+# TODO(BEAM-11327): Remove the need to run tests with UTF-8 encoding
+RUN sed -i '/en_US.UTF-8/s/^# //g' /etc/locale.gen && \
+    locale-gen
+ENV LANG en_US.UTF-8
+ENV LANGUAGE en_US:en
+ENV LC_ALL en_US.UTF-8
+
+###
+# Set Python3.6 as default
+###
+RUN alias python=python3.6
+
+###
+# Install grpcio-tools mypy-protobuf for `python3 sdks/python/setup.py sdist` to work
+###
+RUN pip3 install grpcio-tools mypy-protobuf
+
+###
+# Avoid https://github.com/pypa/virtualenv/issues/2006
+RUN pip3 install distlib==0.3.1

Review comment:
       RUN pip3 install distlib==0.3.1 yapf==0.29.0 pytest 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org