You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by Christian Grobmeier <gr...@gmail.com> on 2009/04/30 09:01:04 UTC
Re: [jira] Resolved: (LOG4PHP-1) Remove @author tags in code and
document credits in README and website
> Why wasn't this change set copied the log4php-cvs@logging.apache.org mailing
> list?
> http://svn.apache.org/viewvc?view=rev&revision=770072
>
> I just found out that some invalid code was commited, fixed here:
> http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/LoggerManager.php?r1=770089&r2=770088&pathrev=770089
>
> I always run a few examples or the unit tests before commit just to make
> sure I didn't break something that at least should have been working before.
Actually I run the checks and its correct at my desk! I feel that
something went wrong with SVN here. I had the bad code, run the
checks, modfied to correct code (like you fixed) and run the test
again. Everything worked, I committed. SVN needed to long fo rmy
taste, but it did.
But now you are telling me that I committed the old code instead of
new. Sorry for that don't know why that happened
Cheers
Re: [jira] Resolved: (LOG4PHP-1) Remove @author tags in code and
document credits in README and website
Posted by Knut Urdalen <kn...@php.no>.
Christian Grobmeier wrote:
> Additionally, I try to check in CHANGELOG, but its always telling me:
> commit -m "#LOG4PHP-1: removed all @author tags. All contributors are
> named (with task) in the changelog file" /Volumes/ANDREW
> 1/Projekte/Entwicklung/log4php-commit-trunk/CHANGELOG
> svn: Commit failed (details follow):
> svn: Commit failed (details follow):
> svn: The specified baseline is not the latest baseline, so it may not
> be checked out.
> svn: CHECKOUT of '/repos/asf/!svn/bln/770071': 409 Conflict
> (https://svn.apache.org)
>
> No update nor a revert helps - I simply cannot commit this file even
> with a totally clean checkout.
>
That's strange... I fixed the change log for you anyway now.
svn up
Maybe a "svn cleanup" would help here?
Knut
Re: [jira] Resolved: (LOG4PHP-1) Remove @author tags in code and
document credits in README and website
Posted by Christian Grobmeier <gr...@gmail.com>.
Additionally, I try to check in CHANGELOG, but its always telling me:
commit -m "#LOG4PHP-1: removed all @author tags. All contributors are
named (with task) in the changelog file" /Volumes/ANDREW
1/Projekte/Entwicklung/log4php-commit-trunk/CHANGELOG
svn: Commit failed (details follow):
svn: Commit failed (details follow):
svn: The specified baseline is not the latest baseline, so it may not
be checked out.
svn: CHECKOUT of '/repos/asf/!svn/bln/770071': 409 Conflict
(https://svn.apache.org)
No update nor a revert helps - I simply cannot commit this file even
with a totally clean checkout.
Christian
On Thu, Apr 30, 2009 at 9:01 AM, Christian Grobmeier
<gr...@gmail.com> wrote:
>> Why wasn't this change set copied the log4php-cvs@logging.apache.org mailing
>> list?
>> http://svn.apache.org/viewvc?view=rev&revision=770072
>>
>> I just found out that some invalid code was commited, fixed here:
>> http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/LoggerManager.php?r1=770089&r2=770088&pathrev=770089
>>
>> I always run a few examples or the unit tests before commit just to make
>> sure I didn't break something that at least should have been working before.
>
>
> Actually I run the checks and its correct at my desk! I feel that
> something went wrong with SVN here. I had the bad code, run the
> checks, modfied to correct code (like you fixed) and run the test
> again. Everything worked, I committed. SVN needed to long fo rmy
> taste, but it did.
> But now you are telling me that I committed the old code instead of
> new. Sorry for that don't know why that happened
>
> Cheers
>
Re: [jira] Resolved: (LOG4PHP-1) Remove @author tags in code and
document credits in README and website
Posted by Knut Urdalen <kn...@php.no>.
Christian Grobmeier wrote:
>
>> For the record I use the following workflow then commiting code:
>>
>> 1. svn status (to check what files I've modified)
>> 2. svn diff (select files if needed)
>> 3. svn ci (select files if needed)
>>
>
> I use eclipse for that.
I only trust the svn-command, I find it hard to work with other tools on
top of it actually. Just my personal preference and lazy not learning
other tools when command line does a great job ;)
Knut
Re: [jira] Resolved: (LOG4PHP-1) Remove @author tags in code and
document credits in README and website
Posted by Christian Grobmeier <gr...@gmail.com>.
> I believe you ;) No problem.
thanks :-)
> For the record I use the following workflow then commiting code:
>
> 1. svn status (to check what files I've modified)
> 2. svn diff (select files if needed)
> 3. svn ci (select files if needed)
I use eclipse for that. I will reinstall my enviroment at home,
hopefully everything works then. However, I will check my committ
before that bad one, just to make sure everything worked there.
Cheers + Thanks for the hint,
Christian
Re: [jira] Resolved: (LOG4PHP-1) Remove @author tags in code and
document credits in README and website
Posted by Knut Urdalen <kn...@php.no>.
Christian Grobmeier wrote:
> Actually I run the checks and its correct at my desk! I feel that
> something went wrong with SVN here. I had the bad code, run the
> checks, modfied to correct code (like you fixed) and run the test
> again. Everything worked, I committed. SVN needed to long fo rmy
> taste, but it did.
>
I believe you ;) No problem.
> But now you are telling me that I committed the old code instead of
> new. Sorry for that don't know why that happened
>
For the record I use the following workflow then commiting code:
1. svn status (to check what files I've modified)
2. svn diff (select files if needed)
3. svn ci (select files if needed)
Knut