You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ha...@apache.org on 2025/09/25 07:40:04 UTC

(skywalking-banyandb) 01/01: Update timeout configurations for liaison services to 1 minute

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch config/write-timeout
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git

commit 6a605e3fe0f7bf26ec6c1130888935139a71ddc9
Author: Gao Hongtao <ha...@gmail.com>
AuthorDate: Thu Sep 25 13:10:24 2025 +0800

    Update timeout configurations for liaison services to 1 minute
    
    - Changed default timeout values for stream, measure, and trace write operations from 15 seconds to 1 minute in server.go.
    - Updated corresponding documentation in configuration.md to reflect the new default timeout settings.
---
 banyand/liaison/grpc/server.go  | 6 +++---
 docs/operation/configuration.md | 5 +++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/banyand/liaison/grpc/server.go b/banyand/liaison/grpc/server.go
index 40e2ba59..e63d6e80 100644
--- a/banyand/liaison/grpc/server.go
+++ b/banyand/liaison/grpc/server.go
@@ -284,9 +284,9 @@ func (s *server) FlagSet() *run.FlagSet {
 	fs.BoolVar(&s.enableQueryAccessLog, "enable-query-access-log", false, "enable query access log")
 	fs.StringVar(&s.accessLogRootPath, "access-log-root-path", "", "access log root path")
 	fs.BoolVar(&s.accessLogSampled, "access-log-sampled", false, "if true, requests may be dropped when the channel is full; if false, requests are never dropped")
-	fs.DurationVar(&s.streamSVC.writeTimeout, "stream-write-timeout", 15*time.Second, "timeout for writing stream among liaison nodes")
-	fs.DurationVar(&s.measureSVC.writeTimeout, "measure-write-timeout", 15*time.Second, "timeout for writing measure among liaison nodes")
-	fs.DurationVar(&s.traceSVC.writeTimeout, "trace-write-timeout", 15*time.Second, "timeout for writing trace among liaison nodes")
+	fs.DurationVar(&s.streamSVC.writeTimeout, "stream-write-timeout", time.Minute, "timeout for writing stream among liaison nodes")
+	fs.DurationVar(&s.measureSVC.writeTimeout, "measure-write-timeout", time.Minute, "timeout for writing measure among liaison nodes")
+	fs.DurationVar(&s.traceSVC.writeTimeout, "trace-write-timeout", time.Minute, "timeout for writing trace among liaison nodes")
 	fs.DurationVar(&s.measureSVC.maxWaitDuration, "measure-metadata-cache-wait-duration", 0,
 		"the maximum duration to wait for metadata cache to load (for testing purposes)")
 	fs.DurationVar(&s.streamSVC.maxWaitDuration, "stream-metadata-cache-wait-duration", 0,
diff --git a/docs/operation/configuration.md b/docs/operation/configuration.md
index b5cdbe5e..84a9c98b 100644
--- a/docs/operation/configuration.md
+++ b/docs/operation/configuration.md
@@ -63,8 +63,9 @@ BanyanDB uses etcd for service discovery and configuration. The following flags
 
 The following flags are used to configure the timeout of data sending from liaison to data servers:
 
-- `--stream-write-timeout duration`: Stream write timeout (default: 15s).
-- `--measure-write-timeout duration`: Measure write timeout (default: 15s).
+- `--stream-write-timeout duration`: Stream write timeout (default: 1m).
+- `--measure-write-timeout duration`: Measure write timeout (default: 1m).
+- `--trace-write-timeout duration`: Trace write timeout (default: 1m).
 
 ### TLS