[GitHub] [incubator-echarts] pissang commented on pull request #12504: feat(tooltip): tooltip formatter trigger once

[GitBox <gi...@apache.org>]

pissang commented on pull request #12504:
URL: https://github.com/apache/incubator-echarts/pull/12504#issuecomment-668460926


   @wf123537200 Sorry for the late review. Some of my thoughts about this pull request:
   
   1. `triggerOnce` should be a more specific name like `formatterCacheResult`. Or it's easy to be mistaken that this tooltip will only show once.
   2. params can be a single object when the trigger is `'item'` in https://github.com/apache/incubator-echarts/pull/12504/files#diff-d5fbb7185a3802482df65d3d3a345c70R598
   3. The key generation logic may have issues in some cases, for example, the key won't change if only the number of series changes. 
   4. Key generation seems to depend on the business logic. So should we add a new option called `formatterCacheKey`? Which is a callback that receives same parameter with formatter and returns a key string.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org