[GitHub] [accumulo] ctubbsii commented on a change in pull request #1302: Refactored tablet loading code to use Ample

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1302: Refactored tablet loading code to use Ample
URL: https://github.com/apache/accumulo/pull/1302#discussion_r309844169
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/MetadataSchema.java
 ##########
 @@ -167,6 +173,20 @@ public static Text getRow(TableId tableId, Text endRow) {
     public static class BulkFileColumnFamily {
       public static final String STR_NAME = "loaded";
       public static final Text NAME = new Text(STR_NAME);
+
+      public static long getBulkLoadTid(Value v) {
+        return getBulkLoadTid(v.toString());
+      }
+
+      public static long getBulkLoadTid(String vs) {
+        if (FateTxId.isFormatedTid(vs)) {
+          return FateTxId.fromString(vs);
+        } else {
+          // a new serialization format was introduce in 2.0. This code support deserializing the
+          // old format.
+          return Long.parseLong(vs);
 
 Review comment:
   https://travis-ci.org/apache/accumulo/jobs/566489719 shows:
   
   ```
   [ERROR]   TabletMetadataTest.testAllColumns:93 » NumberFormat For input string: ""
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services