You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/09/08 13:13:02 UTC

[GitHub] [knox] moresandeep commented on pull request #490: KNOX-2658 - Skipping in-memory lookup while fetching expiration/metadata for a token

moresandeep commented on pull request #490:
URL: https://github.com/apache/knox/pull/490#issuecomment-915227354


   > I'd the idea of replacing the current `ConcurrentHashMap` caches into `Caffeine.Cache` instances but we would still have an issue with eventual consistency within the configured entry TTL in those caches ("margin of error"). I discussed this approach with @zeroflag and we felt that it'd be pre-mature optimization that can be added later if we hit any performance issues. On the other hand, I'm open to re-evaluate that area if we insist this has to be done now.
   
   I see, I am cool with it knowing this has been discussed and will be addressed in the future patches :)
   Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org