You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "abraham-menyhart (via GitHub)" <gi...@apache.org> on 2023/06/02 11:13:32 UTC
[GitHub] [fineract] abraham-menyhart opened a new pull request, #3218: FINERACT-1724: Datatables query API fix - invalid tablename
abraham-menyhart opened a new pull request, #3218:
URL: https://github.com/apache/fineract/pull/3218
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3218: FINERACT-1724: Datatables query API fix - invalid tablename
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3218:
URL: https://github.com/apache/fineract/pull/3218#issuecomment-1577026474
Kindly check the failing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy merged pull request #3218: FINERACT-1724: Datatables query API fix - invalid tablename
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #3218:
URL: https://github.com/apache/fineract/pull/3218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] abraham-menyhart commented on a diff in pull request #3218: FINERACT-1724: Datatables query API fix - invalid tablename
Posted by "abraham-menyhart (via GitHub)" <gi...@apache.org>.
abraham-menyhart commented on code in PR #3218:
URL: https://github.com/apache/fineract/pull/3218#discussion_r1217843580
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1859,6 +1860,14 @@ private String queryForApplicationTableName(final String datatable) {
return applicationTableName;
}
+ private void validateDatatable(final String datatable) {
+ final String sql = "SELECT application_table_name FROM x_registered_table where registered_table_name = ?";
Review Comment:
Yes, already implemented the fix, and I agree with the suggestion. Testing it, but got some env issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] reluxa commented on a diff in pull request #3218: FINERACT-1724: Datatables query API fix - invalid tablename
Posted by "reluxa (via GitHub)" <gi...@apache.org>.
reluxa commented on code in PR #3218:
URL: https://github.com/apache/fineract/pull/3218#discussion_r1217562036
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1859,6 +1860,14 @@ private String queryForApplicationTableName(final String datatable) {
return applicationTableName;
}
+ private void validateDatatable(final String datatable) {
+ final String sql = "SELECT application_table_name FROM x_registered_table where registered_table_name = ?";
Review Comment:
I would have used
```
SELECT count(application_table_name) FROM x_registered_table where registered_table_name = ?
```
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3218: FINERACT-1724: Datatables query API fix - invalid tablename
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3218:
URL: https://github.com/apache/fineract/pull/3218#discussion_r1217861102
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1859,6 +1860,14 @@ private String queryForApplicationTableName(final String datatable) {
return applicationTableName;
}
+ private void validateDatatable(final String datatable) {
+ final String sql = "SELECT application_table_name FROM x_registered_table where registered_table_name = ?";
Review Comment:
feel free to send the fix if your local env problems persist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3218: FINERACT-1724: Datatables query API fix - invalid tablename
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3218:
URL: https://github.com/apache/fineract/pull/3218#discussion_r1217669861
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1859,6 +1860,14 @@ private String queryForApplicationTableName(final String datatable) {
return applicationTableName;
}
+ private void validateDatatable(final String datatable) {
+ final String sql = "SELECT application_table_name FROM x_registered_table where registered_table_name = ?";
Review Comment:
@abraham-menyhart Would you please quickly change this? It would be much nicer with count and easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org